remoting/client/display/gl_renderer.cc - Issue 2886453004: Adding ThreadChecker validation to d'tors for client classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/display/gl_renderer.cc

Issue 2886453004: Adding ThreadChecker validation to d'tors for client classes (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/client/display/gl_renderer.cc

diff --git a/remoting/client/display/gl_renderer.cc b/remoting/client/display/gl_renderer.cc

index 8b2ee234a8dbae570d56f5e88bc5b4864c942e95..2913ff3fb88c8a77c34dc1b955089f354a4ca241 100644

--- a/remoting/client/display/gl_renderer.cc

+++ b/remoting/client/display/gl_renderer.cc

@@ -33,7 +33,9 @@ GlRenderer::GlRenderer() :

thread_checker_.DetachFromThread();

}

-GlRenderer::~GlRenderer() {}

+GlRenderer::~GlRenderer() {

+ DCHECK(thread_checker_.CalledOnValidThread());

void GlRenderer::SetDelegate(base::WeakPtr<GlRendererDelegate> delegate) {

DCHECK(!delegate_);