Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Side by Side Diff: remoting/client/display/gl_renderer.cc

Issue 2886453004: Adding ThreadChecker validation to d'tors for client classes (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/client/display/gl_renderer.h" 5 #include "remoting/client/display/gl_renderer.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 15 matching lines...) Expand all
26 } 26 }
27 27
28 } // namespace 28 } // namespace
29 29
30 GlRenderer::GlRenderer() : 30 GlRenderer::GlRenderer() :
31 weak_factory_(this) { 31 weak_factory_(this) {
32 weak_ptr_ = weak_factory_.GetWeakPtr(); 32 weak_ptr_ = weak_factory_.GetWeakPtr();
33 thread_checker_.DetachFromThread(); 33 thread_checker_.DetachFromThread();
34 } 34 }
35 35
36 GlRenderer::~GlRenderer() {} 36 GlRenderer::~GlRenderer() {
37 DCHECK(thread_checker_.CalledOnValidThread());
38 }
37 39
38 void GlRenderer::SetDelegate(base::WeakPtr<GlRendererDelegate> delegate) { 40 void GlRenderer::SetDelegate(base::WeakPtr<GlRendererDelegate> delegate) {
39 DCHECK(!delegate_); 41 DCHECK(!delegate_);
40 delegate_ = delegate; 42 delegate_ = delegate;
41 } 43 }
42 44
43 void GlRenderer::RequestCanvasSize() { 45 void GlRenderer::RequestCanvasSize() {
44 DCHECK(thread_checker_.CalledOnValidThread()); 46 DCHECK(thread_checker_.CalledOnValidThread());
45 if (delegate_) { 47 if (delegate_) {
46 delegate_->OnSizeChanged(canvas_width_, canvas_height_); 48 delegate_->OnSizeChanged(canvas_width_, canvas_height_);
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 176
175 std::unique_ptr<GlRenderer> GlRenderer::CreateGlRendererWithDesktop() { 177 std::unique_ptr<GlRenderer> GlRenderer::CreateGlRendererWithDesktop() {
176 std::unique_ptr<GlRenderer> renderer(new GlRenderer()); 178 std::unique_ptr<GlRenderer> renderer(new GlRenderer());
177 renderer->AddDrawable(renderer->desktop_.GetWeakPtr()); 179 renderer->AddDrawable(renderer->desktop_.GetWeakPtr());
178 renderer->AddDrawable(renderer->cursor_.GetWeakPtr()); 180 renderer->AddDrawable(renderer->cursor_.GetWeakPtr());
179 renderer->AddDrawable(renderer->cursor_feedback_.GetWeakPtr()); 181 renderer->AddDrawable(renderer->cursor_feedback_.GetWeakPtr());
180 return renderer; 182 return renderer;
181 } 183 }
182 184
183 } // namespace remoting 185 } // namespace remoting
OLDNEW
« no previous file with comments | « remoting/client/display/gl_desktop.cc ('k') | remoting/client/plugin/pepper_video_renderer_2d.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698