Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Issue 2886453002: Use acquire/relase for delayed persistent allocations. (Closed)

Created:
3 years, 7 months ago by bcwhite
Modified:
3 years, 7 months ago
CC:
chromium-reviews, danakj+watch_chromium.org, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use acquire/relase for delayed persistent allocations. Previously, iteration was the safe way to pass allocations between threads & processes. DelayedPersistentAllocations add a second way by storing the reference in a common location so acquire/release must be used when accessing that reference to ensure data integrity of the allocation itself. BUG=722169 Review-Url: https://codereview.chromium.org/2886453002 Cr-Commit-Position: refs/heads/master@{#471795} Committed: https://chromium.googlesource.com/chromium/src/+/17aab96e1dfcdfdd4e4004dd3949b6b0b872dce2

Patch Set 1 #

Patch Set 2 : added comment #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M base/metrics/persistent_histogram_allocator.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/persistent_memory_allocator.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M base/metrics/persistent_memory_allocator.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (17 generated)
bcwhite
3 years, 7 months ago (2017-05-15 14:17:24 UTC) #13
Alexei Svitkine (slow)
lgtm
3 years, 7 months ago (2017-05-15 14:31:38 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886453002/40001
3 years, 7 months ago (2017-05-15 14:39:00 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 16:43:44 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/17aab96e1dfcdfdd4e4004dd3949...

Powered by Google App Engine
This is Rietveld 408576698