Fix sending autofill votes for sign-in forms.

Fix sending autofill votes for sign-in forms.

On CL https://codereview.chromium.org/2796873002/ a sending of autofill votes for sing-in forms was implemented. The problem is that FormData received from the renderer doesn't have values, so Autofill can't figure out any types. This CL adds username value to username field value in FormData structure.

BUG=699530
Review-Url: https://codereview.chromium.org/2886413002
Cr-Commit-Position: refs/heads/master@{#473155}
Committed: https://chromium.googlesource.com/chromium/src/+/6c4e650dc5f0b6f20a9669c0943bd20c18e85ed1

[dvadym, 2017-05-18 13:02:49]

The CQ bit was checked by dvadym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 13:03:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dvadym, 2017-05-18 13:04:45]

Description was changed from

==========
format


Imple

BUG=699530
==========

to

==========
Fix sending autofill votes for sign-in forms.

On CL https://codereview.chromium.org/2796873002/ a sending of autofill votes
for sing-in forms was implemented. The problem is that FormData received from
the renderer doesn't have values, so Autofill can't figure out any types. This
CL adds username value to username field value in FormData structure.

BUG=699530
==========

[dvadym, 2017-05-18 13:04:45]

dvadym@chromium.org changed reviewers:
+ kolos@chromium.org

[dvadym, 2017-05-18 13:06:48]

Hi Maxim,

could you please review this CL?

Regards,
Vadym

[kolos1, 2017-05-18 13:36:25]

https://codereview.chromium.org/2886413002/diff/20001/components/password_man...
File components/password_manager/core/browser/password_form_manager.cc (right):

https://codereview.chromium.org/2886413002/diff/20001/components/password_man...
components/password_manager/core/browser/password_form_manager.cc:1305:
pending_credentials_.form_data.fields[0].value =
As I understand, |field[0]| might be a hidden field, but not the username
element.

[dvadym, 2017-05-18 14:24:42]

https://codereview.chromium.org/2886413002/diff/20001/components/password_man...
File components/password_manager/core/browser/password_form_manager.cc (right):

https://codereview.chromium.org/2886413002/diff/20001/components/password_man...
components/password_manager/core/browser/password_form_manager.cc:1305:
pending_credentials_.form_data.fields[0].value =
On 2017/05/18 13:36:25, kolos1 wrote:
> As I understand, |field[0]| might be a hidden field, but not the username
> element. 

Then |username_value| == "", since we know that there are 2 fields, the first of
them is text field and the second is password. And this is also ok, we just
would receive UNKNOWN_TYPE

[kolos1, 2017-05-18 18:02:55]

On 2017/05/18 14:24:42, dvadym wrote:
>
https://codereview.chromium.org/2886413002/diff/20001/components/password_man...
> File components/password_manager/core/browser/password_form_manager.cc
(right):
> 
>
https://codereview.chromium.org/2886413002/diff/20001/components/password_man...
> components/password_manager/core/browser/password_form_manager.cc:1305:
> pending_credentials_.form_data.fields[0].value =
> On 2017/05/18 13:36:25, kolos1 wrote:
> > As I understand, |field[0]| might be a hidden field, but not the username
> > element. 
> 
> Then |username_value| == "", since we know that there are 2 fields, the first
of
> them is text field and the second is password. And this is also ok, we just
> would receive UNKNOWN_TYPE

There are 2 visible fields, but form data contains the list of all control
element, doesn't it?

[kolos1, 2017-05-18 18:04:00]

On 2017/05/18 18:02:55, kolos1 wrote:
> On 2017/05/18 14:24:42, dvadym wrote:
> >
>
https://codereview.chromium.org/2886413002/diff/20001/components/password_man...
> > File components/password_manager/core/browser/password_form_manager.cc
> (right):
> > 
> >
>
https://codereview.chromium.org/2886413002/diff/20001/components/password_man...
> > components/password_manager/core/browser/password_form_manager.cc:1305:
> > pending_credentials_.form_data.fields[0].value =
> > On 2017/05/18 13:36:25, kolos1 wrote:
> > > As I understand, |field[0]| might be a hidden field, but not the username
> > > element. 
> > 
> > Then |username_value| == "", since we know that there are 2 fields, the
first
> of
> > them is text field and the second is password. And this is also ok, we just
> > would receive UNKNOWN_TYPE
> 
> There are 2 visible fields, but form data contains the list of all control
> element, doesn't it?

There is no filters here
https://cs.chromium.org/chromium/src/components/autofill/content/renderer/for...

[dvadym, 2017-05-19 09:10:48]

I've restructured code a little bit. PTAL

[kolos1, 2017-05-19 09:18:11]

On 2017/05/19 09:10:48, dvadym wrote:
> I've restructured code a little bit. PTAL

LGTM

[dvadym, 2017-05-19 09:18:30]

The CQ bit was checked by dvadym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 09:18:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 09:27:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 09:27:19]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dvadym, 2017-05-19 09:34:35]

The CQ bit was checked by dvadym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 09:35:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dvadym, 2017-05-19 10:53:01]

The CQ bit was unchecked by dvadym@chromium.org

[dvadym, 2017-05-19 10:53:02]

The CQ bit was checked by dvadym@chromium.org

[dvadym, 2017-05-19 10:53:02]

The patchset sent to the CQ was uploaded after l-g-t-m from kolos@chromium.org
Link to the patchset: https://codereview.chromium.org/2886413002/#ps100001
(title: "fix compilation error")

[commit-bot: I haz the power, 2017-05-19 10:53:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 10:58:18]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495191182203480,
"parent_rev": "d317bdebb9123813be9d28e9ff7b128098dfd8ec", "commit_rev":
"6c4e650dc5f0b6f20a9669c0943bd20c18e85ed1"}

[commit-bot: I haz the power, 2017-05-19 10:58:29]

Description was changed from

==========
Fix sending autofill votes for sign-in forms.

On CL https://codereview.chromium.org/2796873002/ a sending of autofill votes
for sing-in forms was implemented. The problem is that FormData received from
the renderer doesn't have values, so Autofill can't figure out any types. This
CL adds username value to username field value in FormData structure.

BUG=699530
==========

to

==========
Fix sending autofill votes for sign-in forms.

On CL https://codereview.chromium.org/2796873002/ a sending of autofill votes
for sing-in forms was implemented. The problem is that FormData received from
the renderer doesn't have values, so Autofill can't figure out any types. This
CL adds username value to username field value in FormData structure.

BUG=699530

Review-Url: https://codereview.chromium.org/2886413002
Cr-Commit-Position: refs/heads/master@{#473155}
Committed:
https://chromium.googlesource.com/chromium/src/+/6c4e650dc5f0b6f20a9669c0943b...
==========

[commit-bot: I haz the power, 2017-05-19 10:58:30]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/6c4e650dc5f0b6f20a9669c0943b...