Issue 2886403005: Remove chrome_download_delegate.cc

Issue 2886403005: Remove chrome_download_delegate.cc (Closed)

Created:
3 years, 7 months ago by qinmin

Modified:
3 years, 7 months ago

Reviewers:
David Trainor- moved to gerrit

CC:
chromium-reviews, David Trainor- moved to gerrit, agrieve+watch_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

Remove chrome_download_delegate.cc We no longer need this file. The java side is still being used for intercepting context menu downloads. Review-Url: https://codereview.chromium.org/2886403005 Cr-Commit-Position: refs/heads/master@{#473010} Committed: https://chromium.googlesource.com/chromium/src/+/92bbc6c123eae7c2d49848014e7a3754b0ff21d0

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -124 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java	View	3 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/BUILD.gn	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/android/chrome_jni_registrar.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
D	chrome/browser/android/download/chrome_download_delegate.h	View	1 chunk	+0 lines, -36 lines	0 comments	Download
D	chrome/browser/android/download/chrome_download_delegate.cc	View	1 chunk	+0 lines, -77 lines	0 comments	Download
M	chrome/browser/android/download/download_controller.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 8 (4 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886403005/1

3 years, 7 months ago (2017-05-18 19:46:47 UTC) #5

commit-bot: I haz the power

3 years, 7 months ago (2017-05-19 01:16:15 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/92bbc6c123eae7c2d49848014e7a...