Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2886403004: PolicyData proto: Obsolete "consumer" ManagementMode (Closed)

Created:
3 years, 7 months ago by Thiemo Nagel
Modified:
3 years, 7 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PolicyData proto: Obsolete "consumer" ManagementMode Removing another remainder of consumer enrollment. BUG=636318 Review-Url: https://codereview.chromium.org/2886403004 Cr-Commit-Position: refs/heads/master@{#472808} Committed: https://chromium.googlesource.com/chromium/src/+/e26133f5e217f0425b7032df60358b9feeb81980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/policy/proto/device_management_backend.proto View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Thiemo Nagel
Hi Dan, may I kindly ask you to take a look at this minor cleanup? ...
3 years, 7 months ago (2017-05-18 14:27:33 UTC) #7
Daniel Erat
lgtm thanks!
3 years, 7 months ago (2017-05-18 14:43:37 UTC) #8
Thiemo Nagel
On 2017/05/18 14:43:37, Daniel Erat wrote: > lgtm > > thanks! Thank you!
3 years, 7 months ago (2017-05-18 14:55:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886403004/1
3 years, 7 months ago (2017-05-18 14:55:59 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 15:01:14 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e26133f5e217f0425b7032df6035...

Powered by Google App Engine
This is Rietveld 408576698