DevTools: Use badges to render products in timeline details.

third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 ProductRegistry.BadgePool = class {
   constructor() {
     this._setting = Common.settings.moduleSetting('product_registry.badges-visible');
     this._setting.addChangeListener(this._settingUpdated.bind(this));
     /** @type {!Map<!Element, function():!Promise<!Common.ParsedURL>>}*/
     this._badgeElements = new Map();
   }
 
   /**
    * @param {!SDK.ResourceTreeFrame} frame
+   * @param {boolean=} showTitle
    * @return {!Element}
    */
-  badgeForFrame(frame) {
-    return this._badgeForFrameOrUrl(this._resolveUrl.bind(this, frame));
+  badgeForFrame(frame, showTitle) {
+    return this._badgeForFrameOrUrl(this._resolveUrl.bind(this, frame), showTitle);
   }
 
   /**
    * @param {!Common.ParsedURL} parsedUrl
+   * @param {boolean=} showTitle
    * @return {!Element}
    */
-  badgeForURL(parsedUrl) {
-    return this._badgeForFrameOrUrl(() => Promise.resolve(parsedUrl));
+  badgeForURL(parsedUrl, showTitle) {
+    return this._badgeForFrameOrUrl(() => Promise.resolve(parsedUrl), showTitle);
   }
 
   reset() {
     this._badgeElements.clear();
   }
 
   /**
    * @param {function():!Promise<!Common.ParsedURL>} urlResolver
+   * @param {boolean=} showTitle
    * @return {!Element}
    */
-  _badgeForFrameOrUrl(urlResolver) {
+  _badgeForFrameOrUrl(urlResolver, showTitle) {
     var element = createElementWithClass('span', 'hidden');
     var root = UI.createShadowRootWithCoreStyles(element, 'product_registry/badge.css');
-    var badgeElement = root.createChild('span', 'product-registry-badge monospace');
-    badgeElement.setAttribute('data-initial', '  ');
-    badgeElement.title = '';
+    var badgeElement = root.createChild('span');
+    badgeElement.classList.toggle('hide-badge-title', !showTitle);
     badgeElement.addEventListener('mousedown', event => event.consume());
     badgeElement.addEventListener('click', event => {
       this._showPopup(badgeElement);
       event.consume();
     }, false);
-
     this._badgeElements.set(badgeElement, urlResolver);
     if (this._setting.get())
       this._renderBadge(badgeElement);
     return element;
   }
 
   /**
    * @param {?SDK.ResourceTreeFrame} frame
    * @return {!Promise<!Common.ParsedURL>}
    */
   async _resolveUrl(frame) {
     var registry = await ProductRegistry.instance();
     var parsedUrl = new Common.ParsedURL(frame.url);
     var entry = registry.entryForUrl(parsedUrl);
     if (!entry) {
       frame.findCreationCallFrame(callFrame => {
         if (!callFrame.url)
           return false;
         parsedUrl = new Common.ParsedURL(callFrame.url);
         return !!registry.entryForUrl(parsedUrl);
       });
     }
     return parsedUrl;
   }
 
   /**
    * @param {!Element} badgeElement
    */
   async _renderBadge(badgeElement) {
-    var registry = await ProductRegistry.instance();
     if (!this._badgeElements.has(badgeElement))
       return;
-    var parsedUrl = await this._badgeElements.get(badgeElement)();
-    var entryName = registry.nameForUrl(parsedUrl);
-
-    if (!entryName) {
-      badgeElement.setAttribute('data-initial', '  ');
-      badgeElement.title = '';
-      badgeElement.style.removeProperty('background-color');
+    if (badgeElement.children.length) {
+      badgeElement.parentNodeOrShadowHost().parentNodeOrShadowHost().classList.remove('hidden');

[pfeldman, 2017/05/18 23:50:36]

extract method?

       return;
     }
 
+    var parsedUrl = await this._badgeElements.get(badgeElement)();
+    var registry = await ProductRegistry.instance();
+    var entryName = registry.nameForUrl(parsedUrl);
+    if (!entryName)
+      return;
+
+    var tokens = entryName.replace(/[a-z]*/g, '').split(' ');
     var label;
-    var tokens = entryName.replace(/[a-z]*/g, '').split(' ');
     if (tokens.length > 1)
       label = tokens[0][0] + tokens[1][0];
     else
       label = entryName;
 
-    badgeElement.setAttribute('data-initial', label.substring(0, 2).toUpperCase());
-    badgeElement.title = entryName;
-    badgeElement.style.backgroundColor = ProductRegistry.BadgePool.colorForEntryName(entryName);
+    var iconElement = badgeElement.createChild('span', 'product-registry-badge monospace');
+    iconElement.setAttribute('data-initial', label.substring(0, 2).toUpperCase());
+    iconElement.title = entryName;
+    iconElement.style.backgroundColor = ProductRegistry.BadgePool.colorForEntryName(entryName);
+
+    badgeElement.createChild('span', 'product-registry-badge-title').textContent = entryName;
     badgeElement.parentNodeOrShadowHost().parentNodeOrShadowHost().classList.toggle('hidden', !this._setting.get());
   }
 
   _settingUpdated() {
     var enabled = this._setting.get();
-    if (!enabled) {
-      for (var badgeElement of this._badgeElements.keys())
+    for (var badgeElement of this._badgeElements.keys()) {
+      if (enabled)

[pfeldman, 2017/05/18 23:50:36]

don't!

+        this._renderBadge(badgeElement);
+      else
         badgeElement.parentNodeOrShadowHost().parentNodeOrShadowHost().classList.add('hidden');
-      return;
     }
-    for (var badgeElement of this._badgeElements.keys())
-      this._renderBadge(badgeElement);
   }
 
   /**
    * @param {!Element} badgeElement
    */
   async _showPopup(badgeElement) {
     if (!this._badgeElements.has(badgeElement))
       return;
 
     var registry = await ProductRegistry.instance();
@@ skipping 26 matching lines @@
    * @return {string}
    */
   static colorForEntryName(entryName) {
     if (!ProductRegistry.BadgePool._colorGenerator) {
       ProductRegistry.BadgePool._colorGenerator =
           new Common.Color.Generator({min: 30, max: 330}, {min: 50, max: 80, count: 3}, 80);
     }
     return ProductRegistry.BadgePool._colorGenerator.colorForID(entryName);
   }
 };