Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-details.html

Issue 2886393003: DevTools: Use badges to render products in timeline details. (Closed)
Patch Set: addressing comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <html> 1 <html>
2 <head> 2 <head>
3 <script src="../../../http/tests/inspector/inspector-test.js"></script> 3 <script src="../../../http/tests/inspector/inspector-test.js"></script>
4 <script src="../../../http/tests/inspector/timeline-test.js"></script> 4 <script src="../../../http/tests/inspector/timeline-test.js"></script>
5 <script> 5 <script>
6 6
7 async function test() 7 async function test()
8 { 8 {
9 var sessionId = "6.23"; 9 var sessionId = "6.23";
10 var rawTraceEvents = [ 10 var rawTraceEvents = [
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 "ts": 101000, 51 "ts": 101000,
52 "dur": 10000, 52 "dur": 10000,
53 "args": { 53 "args": {
54 "data": { 54 "data": {
55 "url": "https://www.google.com", 55 "url": "https://www.google.com",
56 "lineNumber": 1337 56 "lineNumber": 1337
57 } 57 }
58 } 58 }
59 }]; 59 }];
60 60
61 var badgeRendered = Promise.resolve();
62 InspectorTest.addSniffer(ProductRegistry.BadgePool.prototype, "_renderBadge" , (arg, result) => badgeRendered = result, true);
63 Common.settings.moduleSetting('product_registry.badges-visible').set(true);
61 var model = InspectorTest.createPerformanceModelWithEvents(rawTraceEvents).t imelineModel(); 64 var model = InspectorTest.createPerformanceModelWithEvents(rawTraceEvents).t imelineModel();
62 var linkifier = new Components.Linkifier(); 65 var linkifier = new Components.Linkifier();
66 var badgePool = new ProductRegistry.BadgePool();
63 for (var event of model.mainThreadEvents()) { 67 for (var event of model.mainThreadEvents()) {
64 var node = await Timeline.TimelineUIUtils.buildTraceEventDetails(event, model, linkifier); 68 var node = await Timeline.TimelineUIUtils.buildTraceEventDetails(event, model, linkifier, badgePool);
69 await badgeRendered;
65 for (var child of node.querySelectorAll(".timeline-details-view-row")) 70 for (var child of node.querySelectorAll(".timeline-details-view-row"))
66 InspectorTest.addResult(`${child.firstChild.innerText}: ${child.last Child.innerText}`); 71 InspectorTest.addResult(InspectorTest.deepTextContent(child.firstChi ld) + ": " + InspectorTest.deepTextContent(child.lastChild));
67 } 72 }
68 InspectorTest.completeTest(); 73 InspectorTest.completeTest();
69 } 74 }
70 75
71 </script> 76 </script>
72 </head> 77 </head>
73 78
74 <body onload="runTest()"> 79 <body onload="runTest()">
75 <p> 80 <p>
76 Checks the Product property in details pane for a node with URL. 81 Checks the Product property in details pane for a node with URL.
77 </p> 82 </p>
78 </body> 83 </body>
79 </html> 84 </html>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698