DevTools: Use badges to render products in timeline details.

third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 891 matching lines @@
         break;
 
       default:
         var detailsNode =
             Timeline.TimelineUIUtils.buildDetailsNodeForTraceEvent(event, model.targetByEvent(event), linkifier);
         if (detailsNode)
           contentHelper.appendElementRow(Common.UIString('Details'), detailsNode);
         break;
     }
 
-    await Timeline.TimelineUIUtils._maybeAppendProductToDetails(contentHelper, url || eventData && eventData['url']);
+    Timeline.TimelineUIUtils._maybeAppendProductToDetails(contentHelper, url || eventData && eventData['url']);
 
     if (timelineData.timeWaitingForMainThread) {
       contentHelper.appendTextRow(
           Common.UIString('Time Waiting for Main Thread'),
           Number.millisToString(timelineData.timeWaitingForMainThread, true));
     }
 
     var relatedNode = relatedNodesMap && relatedNodesMap.get(timelineData.backendNodeId);
     if (relatedNode) {
       contentHelper.appendElementRow(
@@ skipping 18 matching lines @@
           stats, Timeline.TimelineUIUtils.eventStyle(event).category, event.selfTime);
       contentHelper.appendElementRow('', pieChart);
     }
 
     return contentHelper.fragment;
   }
 
   /**
    * @param {!Timeline.TimelineDetailsContentHelper} contentHelper
    * @param {?string} url
-   * @return {!Promise}
    */
-  static async _maybeAppendProductToDetails(contentHelper, url) {
-    var parsedURL = url && url.asParsedURL();
+  static _maybeAppendProductToDetails(contentHelper, url) {
+    var parsedURL = url ? url.asParsedURL() : null;
     if (!parsedURL)
       return;
-    var registry = await ProductRegistry.instance();
-    var name = registry.nameForUrl(parsedURL);
-    if (name)
-      contentHelper.appendTextRow(Common.UIString('Product'), name);
+    var badgePool = new ProductRegistry.BadgePool();

[pfeldman, 2017/05/18 20:18:34]

Pool is a pool for a reason, you need to reset it or you are leaking the world.

[alph, 2017/05/18 22:56:02]

Done.

+    contentHelper.appendElementRow('', badgePool.badgeForURL(parsedURL, true));
   }
 
   /**
    * @param {!TimelineModel.TimelineModel} model
    * @param {number} startTime
    * @param {number} endTime
    * @return {!DocumentFragment}
    */
   static buildRangeStats(model, startTime, endTime) {
     var aggregatedStats = Timeline.TimelineUIUtils.statsForTimeRange(model, startTime, endTime);
@@ skipping 131 matching lines @@
   static async buildNetworkRequestDetails(request, model, linkifier) {
     const target = model.targetByEvent(request.children[0]);
     const contentHelper = new Timeline.TimelineDetailsContentHelper(target, linkifier);
     const category = Timeline.TimelineUIUtils.networkRequestCategory(request);
     const color = Timeline.TimelineUIUtils.networkCategoryColor(category);
     contentHelper.addSection(Common.UIString('Network request'), color);
 
     const duration = request.endTime - (request.startTime || -Infinity);
     if (request.url)
       contentHelper.appendElementRow(Common.UIString('URL'), Components.Linkifier.linkifyURL(request.url));
-    await Timeline.TimelineUIUtils._maybeAppendProductToDetails(contentHelper, request.url);
+    Timeline.TimelineUIUtils._maybeAppendProductToDetails(contentHelper, request.url);
     if (isFinite(duration))
       contentHelper.appendTextRow(Common.UIString('Duration'), Number.millisToString(duration, true));
     if (request.requestMethod)
       contentHelper.appendTextRow(Common.UIString('Request Method'), request.requestMethod);
     if (typeof request.priority === 'string') {
       const priority =
           NetworkConditions.uiLabelForPriority(/** @type {!Protocol.Network.ResourcePriority} */ (request.priority));
       contentHelper.appendTextRow(Common.UIString('Priority'), priority);
     }
     if (request.mimeType)
@@ skipping 1162 matching lines @@
    * @param {string=} warningType
    */
   appendWarningRow(event, warningType) {
     var warning = Timeline.TimelineUIUtils.eventWarning(event, warningType);
     if (warning)
       this.appendElementRow(Common.UIString('Warning'), warning, true);
   }
 };
 
 Timeline.TimelineUIUtils._categoryBreakdownCacheSymbol = Symbol('categoryBreakdownCache');