Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2886373002: Replace CSSTransitionData::Create(CSSTransition) with clone method. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace CSSTransitionData::Create(CSSTransition) with clone method. To copy a CSSTransitionData, we use CSSTransitionData::Create(o). However, this interface is inconsistent with many other classes that instead provide a clone method to do the same thing. This patch replaces the Create method with a Clone method to be consistent. BUG=628043 Review-Url: https://codereview.chromium.org/2886373002 Cr-Commit-Position: refs/heads/master@{#472720} Committed: https://chromium.googlesource.com/chromium/src/+/c09d13d92f688a3110968dbc2ecad29be8d24e80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M third_party/WebKit/Source/core/animation/css/CSSTransitionData.h View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
shend
Hi Alan, PTAL
3 years, 7 months ago (2017-05-18 03:09:36 UTC) #3
alancutter (OOO until 2018)
lgtm
3 years, 7 months ago (2017-05-18 05:34:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886373002/1
3 years, 7 months ago (2017-05-18 07:14:06 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 07:19:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c09d13d92f688a3110968dbc2eca...

Powered by Google App Engine
This is Rietveld 408576698