Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2886353003:
Remove BrowserAccessibility::platform_node_ (Closed)
|
Created:
3 years, 7 months ago by dougt Modified:
3 years, 7 months ago Reviewers:
dmazzoni CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove BrowserAccessibility::platform_node_
Since we have decided to subclass from AXPlatformNode, we no longer need
to use the platform_node_ variable.
BUG=703369
Review-Url: https://codereview.chromium.org/2886353003
Cr-Commit-Position: refs/heads/master@{#473500}
Committed: https://chromium.googlesource.com/chromium/src/+/501939067a93844fd22780691e362ce74ddabb83
Patch Set 1 #
Total comments: 1
Patch Set 2 : Add comment to GetNativeViewAccessible #Patch Set 3 : spelling overridden #Patch Set 4 : rebase #
Messages
Total messages: 35 (28 generated)
The CQ bit was checked by dougt@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by dougt@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dougt@chromium.org changed reviewers: + dmazzoni@chromium.org
ptal
lgtm https://codereview.chromium.org/2886353003/diff/1/content/browser/accessibili... File content/browser/accessibility/browser_accessibility.cc (right): https://codereview.chromium.org/2886353003/diff/1/content/browser/accessibili... content/browser/accessibility/browser_accessibility.cc:1133: NOTREACHED(); Maybe add a comment saying we should implement this on all platforms then make it abstract? Right now it's unclear reading it if it's a bug that it isn't implemented yet or what.
The CQ bit was checked by dougt@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dmazzoni@chromium.org Link to the patchset: https://codereview.chromium.org/2886353003/#ps40001 (title: "spelling overridden")
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2886353003 Patch 1). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
Description was changed from ========== Remove BrowserAccessibility::platform_node_ Since we have decided to subclass from AXPlatformNode, we no longer need to use the platform_node_ variable. BUG=703369 ========== to ========== Remove BrowserAccessibility::platform_node_ Since we have decided to subclass from AXPlatformNode, we no longer need to use the platform_node_ variable. BUG=703369 NO_DEPENDENCY_CHECKS=true ==========
The CQ bit was checked by dougt@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Description was changed from ========== Remove BrowserAccessibility::platform_node_ Since we have decided to subclass from AXPlatformNode, we no longer need to use the platform_node_ variable. BUG=703369 NO_DEPENDENCY_CHECKS=true ========== to ========== Remove BrowserAccessibility::platform_node_ Since we have decided to subclass from AXPlatformNode, we no longer need to use the platform_node_ variable. BUG=703369 ==========
The CQ bit was checked by dougt@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by dougt@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dougt@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dmazzoni@chromium.org Link to the patchset: https://codereview.chromium.org/2886353003/#ps60001 (title: "rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495424996638510,
"parent_rev": "7856682b892241cb9263140c56554880633b8d84", "commit_rev":
"501939067a93844fd22780691e362ce74ddabb83"}
Message was sent while issue was closed.
Description was changed from ========== Remove BrowserAccessibility::platform_node_ Since we have decided to subclass from AXPlatformNode, we no longer need to use the platform_node_ variable. BUG=703369 ========== to ========== Remove BrowserAccessibility::platform_node_ Since we have decided to subclass from AXPlatformNode, we no longer need to use the platform_node_ variable. BUG=703369 Review-Url: https://codereview.chromium.org/2886353003 Cr-Commit-Position: refs/heads/master@{#473500} Committed: https://chromium.googlesource.com/chromium/src/+/501939067a93844fd22780691e36... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/501939067a93844fd22780691e36... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
