Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: milo/appengine/frontend/expectations/swarming.build-build-timeout.html

Issue 2886353002: Milo: Add an option to hide green steps (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/appengine/frontend/expectations/swarming.build-build-timeout.html
diff --git a/milo/appengine/frontend/expectations/swarming.build-build-timeout.html b/milo/appengine/frontend/expectations/swarming.build-build-timeout.html
index d9f01f9f1a0711b35a9a39cb63d028821e4864c1..e0e5808b7a1a08be924fc67da012031fbf116e59 100644
--- a/milo/appengine/frontend/expectations/swarming.build-build-timeout.html
+++ b/milo/appengine/frontend/expectations/swarming.build-build-timeout.html
@@ -94,9 +94,11 @@
<h2>Steps and Logfiles:</h2>
- <input type="checkbox" id="showHidden">
- <label for="showHidden">Show hidden <span id="numHidden"></span></label>
- <ol id="steps" class="hide">
+ Show:
+ <input type="radio" name="hider" id="showAll"><label for="showAll">All</label>
+ <input type="radio" name="hider" id="showStandard" checked><label for="showStandard">Standard</label>
+ <input type="radio" name="hider" id="showFail"><label for="showFail">Failure</label>
+ <ol id="steps" class="standard">
@@ -251,24 +253,35 @@
</div>
<script language="javascript">
$(document).ready(function() {
- var check = function(checked) {
+
+ var check = function(filter) {
var things = $("#steps");
- if (checked) {
- $("#steps").removeClass("hide");
- } else {
- $("#steps").addClass("hide");
- }
- var numHidden = $(".verbosity-Hidden").length;
- if (numHidden > 0) {
- $("#numHidden").text("(" + numHidden + " hidden)");
+ if (filter == "fail") {
+ $("#steps").removeClass("standard");
+ $("#steps").removeClass("all");
+ $("#steps").addClass("fail");
+ } else if (filter == "all") {
+ $("#steps").removeClass("standard");
+ $("#steps").addClass("all");
+ $("#steps").removeClass("fail");
} else {
- $("#numHidden").text("");
+
+ $("#steps").removeClass("all");
+ $("#steps").addClass("standard");
+ $("#steps").removeClass("fail");
}
};
- check($("#showHidden").is(":checked"));
- $("#showHidden").click(function(e) {
- check($(this).is(":checked"));
+ check($("#showFail").is(":checked"), "standard");
+
+ $("#showFail").click(function(e) {
+ check("fail");
+ });
+ $("#showStandard").click(function(e) {
+ check("standard");
+ });
+ $("#showAll").click(function(e) {
+ check("all");
});
});
</script>

Powered by Google App Engine
This is Rietveld 408576698