Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: milo/appengine/buildbot/build.go

Issue 2886353002: Milo: Add an option to hide green steps (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/appengine/buildbot/build.go
diff --git a/milo/appengine/buildbot/build.go b/milo/appengine/buildbot/build.go
index 5f0b92f19d184d867e89981ad33f97e4f5381581..840242e5630c964525241b82e963e3d6b5fdc815 100644
--- a/milo/appengine/buildbot/build.go
+++ b/milo/appengine/buildbot/build.go
@@ -226,6 +226,12 @@ func components(b *buildbotBuild) (result []*resp.BuildComponent) {
}
}
+ // Raise the interesting-ness based off status.
+ switch bc.Status {
+ case resp.Running, resp.Failure, resp.InfraFailure, resp.Exception, resp.Warning, resp.WaitingDependency:
nodir 2017/05/18 02:41:04 it seems that all but Success is interesting? if
Ryan Tseng 2017/05/18 22:52:48 Done.
+ bc.Verbosity = resp.Interesting
+ }
+
remainingAliases := stringset.New(len(step.Aliases))
for linkAnchor := range step.Aliases {
remainingAliases.Add(linkAnchor)

Powered by Google App Engine
This is Rietveld 408576698