Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2660)

Unified Diff: milo/appengine/frontend/expectations/swarming.build-Basic_successful_build.html

Issue 2886353002: Milo: Add an option to hide green steps (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/appengine/frontend/expectations/swarming.build-Basic_successful_build.html
diff --git a/milo/appengine/frontend/expectations/swarming.build-Basic_successful_build.html b/milo/appengine/frontend/expectations/swarming.build-Basic_successful_build.html
index dbe8d9c577f93f63d38b0f33dca6fc2b100715e2..32225d54aa8662ac320aa9c61a39ceec0e3089be 100644
--- a/milo/appengine/frontend/expectations/swarming.build-Basic_successful_build.html
+++ b/milo/appengine/frontend/expectations/swarming.build-Basic_successful_build.html
@@ -102,24 +102,35 @@
</div>
<script language="javascript">
$(document).ready(function() {
- var check = function(checked) {
+
+ var check = function(filter) {
var things = $("#steps");
- if (checked) {
- $("#steps").removeClass("hide");
- } else {
- $("#steps").addClass("hide");
- }
- var numHidden = $(".verbosity-Hidden").length;
- if (numHidden > 0) {
- $("#numHidden").text("(" + numHidden + " hidden)");
+ if (filter == "fail") {
+ $("#steps").removeClass("standard");
+ $("#steps").removeClass("all");
+ $("#steps").addClass("fail");
+ } else if (filter == "all") {
+ $("#steps").removeClass("standard");
+ $("#steps").addClass("all");
+ $("#steps").removeClass("fail");
} else {
- $("#numHidden").text("");
+
+ $("#steps").removeClass("all");
+ $("#steps").addClass("standard");
+ $("#steps").removeClass("fail");
}
};
- check($("#showHidden").is(":checked"));
- $("#showHidden").click(function(e) {
- check($(this).is(":checked"));
+ check($("#showFail").is(":checked"), "standard");
+
+ $("#showFail").click(function(e) {
+ check("fail");
+ });
+ $("#showStandard").click(function(e) {
+ check("standard");
+ });
+ $("#showAll").click(function(e) {
+ check("all");
});
});
</script>

Powered by Google App Engine
This is Rietveld 408576698