Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1400)

Issue 2886343003: Fix metric collection for shell apk version. (Closed)

Created:
11 months, 1 week ago by Yaron
Modified:
11 months, 1 week ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org, pkotwicz
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix metric collection for shell apk version. The implicit separator is '_' but the metric is recorded with '.' BUG=691743 Review-Url: https://codereview.chromium.org/2886343003 Cr-Commit-Position: refs/heads/master@{#473203} Committed: https://chromium.googlesource.com/chromium/src/+/7586aa67fae852113735474c358205cef090e843

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
Yaron
11 months, 1 week ago (2017-05-18 19:52:12 UTC) #2
Yaron
11 months, 1 week ago (2017-05-18 19:52:13 UTC) #3
Ilya Sherman
LGTM, thanks. It's probably time to reverse that default... dot is much more common than ...
11 months, 1 week ago (2017-05-18 20:32:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886343003/1
11 months, 1 week ago (2017-05-18 21:05:28 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/449392)
11 months, 1 week ago (2017-05-19 03:49:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886343003/1
11 months, 1 week ago (2017-05-19 14:50:37 UTC) #13
commit-bot: I haz the power
11 months, 1 week ago (2017-05-19 15:52:30 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7586aa67fae852113735474c3582...

Powered by Google App Engine
This is Rietveld 408576698