Register files with new drivers (issue 29641)

Register files with new drivers (issue 29641)

Committed: https://github.com/dart-lang/sdk/commit/091752f158af6866092cc252791802a004582d42

[Brian Wilkerson, 2017-05-18 00:23:23]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-05-18 01:20:40]

https://codereview.chromium.org/2886343002/diff/1/pkg/analyzer_plugin/lib/plu...
File pkg/analyzer_plugin/lib/plugin/plugin.dart (right):

https://codereview.chromium.org/2886343002/diff/1/pkg/analyzer_plugin/lib/plu...
pkg/analyzer_plugin/lib/plugin/plugin.dart:472: if (excluded.contains(path) ||
!resource.exists) {
It does not guarantee anything that the resource exists now.
It might be removed the next millisecond.

https://codereview.chromium.org/2886343002/diff/1/pkg/analyzer_plugin/lib/plu...
pkg/analyzer_plugin/lib/plugin/plugin.dart:478: for (Resource child in
resource.getChildren()) {
getChildren() should be wrapped with try/catch in case of a FileSystemException,
because the folder does not exist anymore, the user does not have rights to list
it, etc.

[Brian Wilkerson, 2017-05-18 14:43:36]

https://codereview.chromium.org/2886343002/diff/1/pkg/analyzer_plugin/lib/plu...
File pkg/analyzer_plugin/lib/plugin/plugin.dart (right):

https://codereview.chromium.org/2886343002/diff/1/pkg/analyzer_plugin/lib/plu...
pkg/analyzer_plugin/lib/plugin/plugin.dart:472: if (excluded.contains(path) ||
!resource.exists) {
I removed the existence check.

https://codereview.chromium.org/2886343002/diff/1/pkg/analyzer_plugin/lib/plu...
pkg/analyzer_plugin/lib/plugin/plugin.dart:478: for (Resource child in
resource.getChildren()) {
Done

[Brian Wilkerson, 2017-05-18 14:43:51]

Description was changed from

==========
Register files with new drivers (issue 29641)
==========

to

==========
Register files with new drivers (issue 29641)

Committed:
https://github.com/dart-lang/sdk/commit/091752f158af6866092cc252791802a004582d42
==========

[Brian Wilkerson, 2017-05-18 14:43:53]

Committed patchset #1 (id:1) manually as
091752f158af6866092cc252791802a004582d42 (presubmit successful).