Register files with new drivers (issue 29641)

pkg/analyzer_plugin/lib/plugin/plugin.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/file_system/physical_file_system.dart';
 import 'package:analyzer/src/dart/analysis/driver.dart'
     show AnalysisDriverGeneric, AnalysisDriverScheduler;
@@ skipping 251 matching lines @@
   Future<AnalysisSetContextRootsResult> handleAnalysisSetContextRoots(
       AnalysisSetContextRootsParams parameters) async {
     List<ContextRoot> contextRoots = parameters.roots;
     List<ContextRoot> oldRoots = driverMap.keys.toList();
     for (ContextRoot contextRoot in contextRoots) {
       if (!oldRoots.remove(contextRoot)) {
         // The context is new, so we create a driver for it. Creating the driver
         // has the side-effect of adding it to the analysis driver scheduler.
         AnalysisDriverGeneric driver = createAnalysisDriver(contextRoot);
         driverMap[contextRoot] = driver;
+        _addFilesToDriver(
+            driver,
+            resourceProvider.getResource(contextRoot.root),
+            contextRoot.exclude);
       }
     }
     for (ContextRoot contextRoot in oldRoots) {
       // The context has been removed, so we remove its driver.
       AnalysisDriverGeneric driver = driverMap.remove(contextRoot);
       // The `dispose` method has the side-effect of removing the driver from
       // the analysis driver scheduler.
       driver.dispose();
     }
     return new AnalysisSetContextRootsResult();
@@ skipping 170 matching lines @@
 
   /**
    * Start this plugin by listening to the given communication [channel].
    */
   void start(PluginCommunicationChannel channel) {
     _channel = channel;
     _channel.listen(_onRequest, onError: onError, onDone: onDone);
   }
 
   /**
+   * Add all of the files contained in the given [resource] that are not in the
+   * list of [excluded] resources to the given [driver].
+   */
+  void _addFilesToDriver(
+      AnalysisDriverGeneric driver, Resource resource, List<String> excluded) {
+    String path = resource.path;
+    if (excluded.contains(path) || !resource.exists) {

[scheglov, 2017/05/18 01:20:40]

It does not guarantee anything that the resource exists now.
It might be removed the next millisecond.

[Brian Wilkerson, 2017/05/18 14:43:36]

I removed the existence check.

+      return;
+    }
+    if (resource is File) {
+      driver.addFile(path);
+    } else if (resource is Folder) {
+      for (Resource child in resource.getChildren()) {

[scheglov, 2017/05/18 01:20:40]

getChildren() should be wrapped with try/catch in case of a FileSystemException,
because the folder does not exist anymore, the user does not have rights to list
it, etc.

[Brian Wilkerson, 2017/05/18 14:43:36]

Done

+        _addFilesToDriver(driver, child, excluded);
+      }
+    }
+  }
+
+  /**
    * Compute the response that should be returned for the given [request], or
    * `null` if the response has already been sent.
    */
   Future<Response> _getResponse(Request request) async {
     ResponseResult result = null;
     switch (request.method) {
       case ANALYSIS_REQUEST_HANDLE_WATCH_EVENTS:
         var params = new AnalysisHandleWatchEventsParams.fromRequest(request);
         result = await handleAnalysisHandleWatchEvents(params);
         break;
@@ skipping 76 matching lines @@
       response = new Response(id,
           error: new RequestError(
               RequestErrorCode.PLUGIN_ERROR, exception.toString(),
               stackTrace: stackTrace.toString()));
     }
     if (response != null) {
       _channel.sendResponse(response);
     }
   }
 }