Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 2886323003: Remove importing CSS for results details page. (Closed)

Created:
3 years, 7 months ago by mikecase (-- gone --)
Modified:
3 years, 7 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove importing CSS for results details page. Removing this for a few reasons. (1) We don't use much CSS from the file we import. (2) It couples our results details page with the waterfall CSS file (things like classnames info/interface were used in that CSS but don't seem to do anything special just looking at results detail page) and (3) we might want local result detail pages eventually. Review-Url: https://codereview.chromium.org/2886323003 Cr-Commit-Position: refs/heads/master@{#472903} Committed: https://chromium.googlesource.com/chromium/src/+/e99ade7b40d361233acfad8d735dc66a34799de6

Patch Set 1 #

Patch Set 2 : black links #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -7 lines) Patch
M build/android/pylib/results/presentation/template/main.html View 1 2 chunks +32 lines, -5 lines 0 comments Download
M build/android/pylib/results/presentation/template/table.html View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/results/presentation/test_results_presentation.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
mikecase (-- gone --)
I'll double check before committing, but the result detail page looks identical (and I even ...
3 years, 7 months ago (2017-05-18 02:02:44 UTC) #2
jbudorick
Fired a couple of trybots to make sure this looks ok. Code looks fine. Will ...
3 years, 7 months ago (2017-05-18 03:13:43 UTC) #4
jbudorick
On 2017/05/18 03:13:43, jbudorick wrote: > Fired a couple of trybots to make sure this ...
3 years, 7 months ago (2017-05-18 13:30:37 UTC) #5
mikecase (-- gone --)
On 2017/05/18 at 13:30:37, jbudorick wrote: > On 2017/05/18 03:13:43, jbudorick wrote: > > Fired ...
3 years, 7 months ago (2017-05-18 14:50:41 UTC) #6
mikecase (-- gone --)
fixed
3 years, 7 months ago (2017-05-18 15:22:44 UTC) #7
jbudorick
lgtm
3 years, 7 months ago (2017-05-18 15:24:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886323003/20001
3 years, 7 months ago (2017-05-18 19:30:12 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 19:36:32 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e99ade7b40d361233acfad8d735d...

Powered by Google App Engine
This is Rietveld 408576698