Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2886303003: [ObjC ARC] Converts ios/chrome/test/earl_grey:ios_chrome_multitasking_egtests to ARC. (Closed)

Created:
3 years, 7 months ago by liaoyuke
Modified:
3 years, 6 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, baxley+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, huangml+watch_chromium.org, liaoyuke+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/test/earl_grey:ios_chrome_multitasking_egtests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2886303003 Cr-Commit-Position: refs/heads/master@{#477505} Committed: https://chromium.googlesource.com/chromium/src/+/bd4f183e08c8bbcc95b65eee4b2949ac53b87679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M ios/chrome/app/multitasking_test_application_delegate.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/chrome/test/earl_grey/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 28 (15 generated)
liaoyuke
Hey Mike, PTAL. Thank you very much!
3 years, 7 months ago (2017-05-18 18:12:05 UTC) #6
baxley
lgtm
3 years, 7 months ago (2017-05-18 22:23:24 UTC) #7
baxley
lgtm lgtm
3 years, 7 months ago (2017-05-18 22:23:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886303003/1
3 years, 7 months ago (2017-05-18 22:29:25 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/441732)
3 years, 7 months ago (2017-05-18 22:40:58 UTC) #12
liaoyuke
Hi Mark, PTAL for owner's approval. Thank you very much!
3 years, 6 months ago (2017-05-30 17:21:19 UTC) #14
marq (ping after 24h)
lgtm
3 years, 6 months ago (2017-05-30 17:40:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886303003/1
3 years, 6 months ago (2017-05-30 20:08:38 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/226543)
3 years, 6 months ago (2017-05-30 21:40:44 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886303003/1
3 years, 6 months ago (2017-06-06 22:37:40 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/232023)
3 years, 6 months ago (2017-06-06 23:58:14 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886303003/1
3 years, 6 months ago (2017-06-07 01:08:39 UTC) #25
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 01:26:58 UTC) #28
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bd4f183e08c8bbcc95b65eee4b29...

Powered by Google App Engine
This is Rietveld 408576698