Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issue 2886293004: Remove references to inherited_data_ in ComputedStyle. (Closed)

Created:
6 months, 1 week ago by shend
Modified:
6 months, 1 week ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove references to inherited_data_ in ComputedStyle. To allow changes to where fields are stored, ComputedStyle code should not refer directly to a group, as that code will break when we change groups. This patch removes references to inherited_data_ in ComputedStyle, replacing with generated or handwritten getters. This patch does not remove references within diffing functions as those will soon be generated. BUG=710938 Review-Url: https://codereview.chromium.org/2886293004 Cr-Commit-Position: refs/heads/master@{#473433} Committed: https://chromium.googlesource.com/chromium/src/+/1b298605df3e00d8bb378fb2c17a8014d0d1c578

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 6 chunks +11 lines, -11 lines 0 comments Download
Trybot results:  win_clang   win_chromium_rel_ng   win_chromium_x64_rel_ng   win_chromium_compile_dbg_ng   ios-simulator-xcode-clang   mac_chromium_compile_dbg_ng   mac_chromium_rel_ng   ios-simulator   ios-device-xcode-clang   linux_chromium_tsan_rel_ng   linux_chromium_rel_ng   ios-device   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_rel_ng   linux_chromium_asan_rel_ng   linux_chromium_chromeos_ozone_rel_ng   chromium_presubmit   chromeos_daisy_chromium_compile_only_ng   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_android   cast_shell_linux   linux_android_rel_ng   android_n5x_swarming_rel   android_cronet   android_compile_dbg   android_arm64_dbg_recipe   android_clang_dbg_recipe   win_chromium_x64_rel_ng   chromium_presubmit   win_chromium_x64_rel_ng   win_clang   win_chromium_rel_ng   win_chromium_x64_rel_ng   win_chromium_compile_dbg_ng   mac_chromium_rel_ng   mac_chromium_compile_dbg_ng   ios-simulator   ios-simulator-xcode-clang   ios-device-xcode-clang   ios-device   linux_chromium_tsan_rel_ng   linux_chromium_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_ozone_rel_ng   chromium_presubmit   linux_chromium_asan_rel_ng   chromeos_daisy_chromium_compile_only_ng   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_linux   cast_shell_android   linux_android_rel_ng   android_n5x_swarming_rel   android_cronet   android_compile_dbg   android_clang_dbg_recipe   android_arm64_dbg_recipe 

Messages

Total messages: 21 (17 generated)
shend
Hi Alan, PTAL
6 months, 1 week ago (2017-05-19 00:01:35 UTC) #3
alancutter (OOO until 2018)
lgtm
6 months, 1 week ago (2017-05-19 01:12:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886293004/20001
6 months, 1 week ago (2017-05-20 10:46:13 UTC) #18
commit-bot: I haz the power
6 months, 1 week ago (2017-05-20 12:45:02 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1b298605df3e00d8bb378fb2c17a...

Powered by Google App Engine
This is Rietveld efc10ee0f