chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc - Issue 2886293002: Remove WINDOW_TYPE_V1_PANEL AppWindow type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

Issue 2886293002: Remove WINDOW_TYPE_V1_PANEL AppWindow type (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/tabs/tabs_api.cc ('K') | « chrome/browser/ui/views/apps/chrome_native_app_window_views.cc ('k') | extensions/browser/app_window/app_window.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

diff --git a/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc b/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

index ef0430f6ed48a8cdae11a0bd5211ecf32ad44df2..3f2413477109223e9ef751de0ec233df8d0e56d2 100644

--- a/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

+++ b/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

@@ -166,7 +166,6 @@ void ChromeNativeAppWindowViewsAuraAsh::OnBeforeWidgetInit(

}

DCHECK_NE(AppWindow::WINDOW_TYPE_PANEL, create_params.window_type);

- DCHECK_NE(AppWindow::WINDOW_TYPE_V1_PANEL, create_params.window_type);

init_params->mus_properties

[ui::mojom::WindowManager::kRemoveStandardFrame_InitProperty] =

mojo::ConvertTo<std::vector<uint8_t>>(init_params->remove_standard_frame);