Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2886253003:
Make sure to only call valid GL query functions when processing queries. (Closed)
|
Created:
3 years, 7 months ago by Geoff Lang Modified:
3 years, 7 months ago Reviewers:
piman CC:
chromium-reviews, piman+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake sure to only call valid GL query functions when processing queries.
Both glGetQueryObjectiv and glGetQueryObjectui64v are not available
without disjoint timer queries on OpenGL ES.
BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2886253003
Cr-Commit-Position: refs/heads/master@{#474694}
Committed: https://chromium.googlesource.com/chromium/src/+/ad504b2f5de06ad7e437d0fc8378f7f126ef88ed
Patch Set 1 #
Messages
Total messages: 18 (14 generated)
Description was changed from ========== Make sure to only call valid GL query functions when processing queries. Both glGetQueryObjectiv and glGetQueryObjectui64v are not available without disjoint timer queries on OpenGL ES. BUG=602688 ========== to ========== Make sure to only call valid GL query functions when processing queries. Both glGetQueryObjectiv and glGetQueryObjectui64v are not available without disjoint timer queries on OpenGL ES. BUG=602688 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Make sure to only call valid GL query functions when processing queries. Both glGetQueryObjectiv and glGetQueryObjectui64v are not available without disjoint timer queries on OpenGL ES. BUG=602688 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Make sure to only call valid GL query functions when processing queries. Both glGetQueryObjectiv and glGetQueryObjectui64v are not available without disjoint timer queries on OpenGL ES. BUG=602688 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
geofflang@chromium.org changed reviewers: + piman@chromium.org
PTAL, this caused ANGLE's D3D9 backend to fail for query-related tests.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by geofflang@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495734229973120, "parent_rev":
"4e9fc10cf30e41afad38069847381cd725c2acbe", "commit_rev":
"ad504b2f5de06ad7e437d0fc8378f7f126ef88ed"}
Message was sent while issue was closed.
Description was changed from ========== Make sure to only call valid GL query functions when processing queries. Both glGetQueryObjectiv and glGetQueryObjectui64v are not available without disjoint timer queries on OpenGL ES. BUG=602688 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Make sure to only call valid GL query functions when processing queries. Both glGetQueryObjectiv and glGetQueryObjectui64v are not available without disjoint timer queries on OpenGL ES. BUG=602688 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2886253003 Cr-Commit-Position: refs/heads/master@{#474694} Committed: https://chromium.googlesource.com/chromium/src/+/ad504b2f5de06ad7e437d0fc8378... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ad504b2f5de06ad7e437d0fc8378... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
