Issue 2886193003: Handle diagnostic messages from analyzer that lack a URI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2886193003: Handle diagnostic messages from analyzer that lack a URI. (Closed)

Created:
3 years, 7 months ago by Paul Berry

Modified:
3 years, 7 months ago

Reviewers:
ahe, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Handle diagnostic messages from analyzer that lack a URI. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/8ea1906e5410d55dec1305325e0458026570ca2e

Patch Set 1 #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/testing/lib/src/analyze.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

Committed patchset #1 (id:1) manually as 8ea1906e5410d55dec1305325e0458026570ca2e (presubmit successful).

3 years, 7 months ago (2017-05-17 21:17:54 UTC) #6

ahe

3 years, 7 months ago (2017-05-18 10:19:17 UTC) #7

Message was sent while issue was closed.

lgtm

Thank you!

This just stresses the fact that I need to land my branch:
https://user.git.corp.google.com/ahe/dart-sdk/+/misc/pkg/testing/lib/src/anal...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages