Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: pkg/testing/lib/src/analyze.dart

Issue 2886193003: Handle diagnostic messages from analyzer that lack a URI. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/testing/lib/src/analyze.dart
diff --git a/pkg/testing/lib/src/analyze.dart b/pkg/testing/lib/src/analyze.dart
index 85e4dcc6a46528ccaf974839bb86d9275f2664f9..38324578eb580224d94f9e0b942070cef0c29921 100644
--- a/pkg/testing/lib/src/analyze.dart
+++ b/pkg/testing/lib/src/analyze.dart
@@ -166,7 +166,7 @@ Future<Null> analyzeUris(Uri analysisOptions, Uri packages, List<Uri> uris,
bool hasOutput = false;
Set<String> seen = new Set<String>();
for (AnalyzerDiagnostic diagnostic in diagnostics) {
- String path = diagnostic.uri.path;
+ String path = diagnostic.uri?.path ?? "<unknown>";
if (exclude.any((RegExp r) => path.contains(r))) continue;
String message = "$diagnostic";
if (seen.add(message)) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698