Issue 2886163002: Disable WebRtcVideoQualityBrowserTest.TestVideoQualityH264/0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2886163002: Disable WebRtcVideoQualityBrowserTest.TestVideoQualityH264/0 (Closed)

Created:
3 years, 7 months ago by philipel1

Modified:
3 years, 7 months ago

Reviewers:
philipel2, tommi (sloooow) - chröme

CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, phoglund+watch_chromium.org, feature-media-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable WebRtcVideoQualityBrowserTest.TestVideoQualityH264/0 BUG=chromium:722746

Patch Set 1 #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

henrika (OOO until Aug 14)

Should it be disabled on all platforms? I have only seen issues on Win10.

3 years, 7 months ago (2017-05-17 14:10:17 UTC) #3

tommi (sloooow) - chröme

On 2017/05/17 14:10:17, henrika wrote: > Should it be disabled on all platforms? > I ...

3 years, 7 months ago (2017-05-17 16:11:01 UTC) #4

philipel2

3 years, 7 months ago (2017-05-18 08:29:20 UTC) #5

On 2017/05/17 16:11:01, tommi (sloooow) - chröme wrote:
> On 2017/05/17 14:10:17, henrika wrote:
> > Should it be disabled on all platforms?
> > I have only seen issues on Win10.
> 
> Agree - let's only disable for the configuration+platform we're seeing issues
> on.

Done.


> Also, you might have to upload the change again with the right account (and no
> need to put yourself in the reviewer list :)).

Oops, re-uploaded it here https://codereview.chromium.org/2893523004 with the
correct account, closing this issue.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages