Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2886133003:
Only call paint property-requiring subroutines if there are actually properties. (Closed)
DescriptionOnly call paint property-requiring subroutines if there are actually properties.
Local testing seems to show a 10% or so performance improvement on
Paint/complex-content-slow-scroll.html.
BUG=718045
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2886133003
Cr-Commit-Position: refs/heads/master@{#472846}
Committed: https://chromium.googlesource.com/chromium/src/+/1b3799fee23bfbfc578c184236a4b3f663509f95
Patch Set 1 #Patch Set 2 : none #Patch Set 3 : none #Patch Set 4 : none #Patch Set 5 : Merge branch 'master' into paintpropertiesoptimized #
Messages
Total messages: 30 (24 generated)
Description was changed from ========== none none none none BUG= ========== to ========== none none none none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
Description was changed from ========== none none none none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Only call paint property-requiring subroutines if there are actually properties. BUG=718045 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by chrishtr@chromium.org
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by chrishtr@chromium.org
Description was changed from ========== Only call paint property-requiring subroutines if there are actually properties. BUG=718045 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Only call paint property-requiring subroutines if there are actually properties. Local testing seems to show a 10% or so performance improvemnet on Paint/complex-content-slow-scroll.html. BUG=718045 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
chrishtr@chromium.org changed reviewers: + pdr@chromium.org
Description was changed from ========== Only call paint property-requiring subroutines if there are actually properties. Local testing seems to show a 10% or so performance improvemnet on Paint/complex-content-slow-scroll.html. BUG=718045 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Only call paint property-requiring subroutines if there are actually properties. Local testing seems to show a 10% or so performance improvement on Paint/complex-content-slow-scroll.html. BUG=718045 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/05/17 at 18:45:26, chrishtr wrote: > LGTM
The CQ bit was unchecked by chrishtr@chromium.org
The CQ bit was checked by chrishtr@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by chrishtr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org Link to the patchset: https://codereview.chromium.org/2886133003/#ps80001 (title: "Merge branch 'master' into paintpropertiesoptimized")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495119369796960,
"parent_rev": "7615be681fe875bc5e6e5715e1455bbffa0a5eb3", "commit_rev":
"1b3799fee23bfbfc578c184236a4b3f663509f95"}
Message was sent while issue was closed.
Description was changed from ========== Only call paint property-requiring subroutines if there are actually properties. Local testing seems to show a 10% or so performance improvement on Paint/complex-content-slow-scroll.html. BUG=718045 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Only call paint property-requiring subroutines if there are actually properties. Local testing seems to show a 10% or so performance improvement on Paint/complex-content-slow-scroll.html. BUG=718045 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2886133003 Cr-Commit-Position: refs/heads/master@{#472846} Committed: https://chromium.googlesource.com/chromium/src/+/1b3799fee23bfbfc578c184236a4... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/1b3799fee23bfbfc578c184236a4... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
