CHECK() that AD user policy is only created on AD-managed devices

CHECK() that AD user policy is only created on AD-managed devices

There's other code that prevents AD users from logging in to non-AD
devices but it's clearer to have a CHECK() in
UserPolicyManagerFactoryChromeOS::CreateManagerForProfile() instead of
just returning an empty ConfigurationPolicyProvider.

BUG=722374
Review-Url: https://codereview.chromium.org/2886133002
Cr-Commit-Position: refs/heads/master@{#472456}
Committed: https://chromium.googlesource.com/chromium/src/+/13bf054add652e093b9519088e2998174e29fee3

[Thiemo Nagel, 2017-05-17 10:45:26]

The CQ bit was checked by tnagel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 10:45:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Thiemo Nagel, 2017-05-17 10:48:10]

tnagel@chromium.org changed reviewers:
+ atwilson@chromium.org

[Thiemo Nagel, 2017-05-17 10:48:11]

PTAL

[commit-bot: I haz the power, 2017-05-17 11:17:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 11:17:55]

Dry run: This issue passed the CQ dry run.

[Andrew T Wilson (Slow), 2017-05-17 15:04:35]

lgtm

[Thiemo Nagel, 2017-05-17 15:06:28]

The CQ bit was checked by tnagel@chromium.org

[commit-bot: I haz the power, 2017-05-17 15:07:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 15:13:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495033588878750, "parent_rev":
"7dadef7920fa13a23f2957f61993f079d173dc48", "commit_rev":
"13bf054add652e093b9519088e2998174e29fee3"}

[commit-bot: I haz the power, 2017-05-17 15:13:49]

Description was changed from

==========
CHECK() that AD user policy is only created on AD-managed devices

There's other code that prevents AD users from logging in to non-AD
devices but it's clearer to have a CHECK() in
UserPolicyManagerFactoryChromeOS::CreateManagerForProfile() instead of
just returning an empty ConfigurationPolicyProvider.

BUG=722374
==========

to

==========
CHECK() that AD user policy is only created on AD-managed devices

There's other code that prevents AD users from logging in to non-AD
devices but it's clearer to have a CHECK() in
UserPolicyManagerFactoryChromeOS::CreateManagerForProfile() instead of
just returning an empty ConfigurationPolicyProvider.

BUG=722374

Review-Url: https://codereview.chromium.org/2886133002
Cr-Commit-Position: refs/heads/master@{#472456}
Committed:
https://chromium.googlesource.com/chromium/src/+/13bf054add652e093b9519088e29...
==========

[commit-bot: I haz the power, 2017-05-17 15:13:50]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/13bf054add652e093b9519088e29...