third_party/WebKit/Source/core/dom/Modulator.h - Issue 2886123002: Revert of [ES6 modules] ModuleMap::GetFetchedModuleScript to return nullptr when entry not found / "fetching"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Modulator.h

Issue 2886123002: Revert of [ES6 modules] ModuleMap::GetFetchedModuleScript to return nullptr when entry not found / "fetching" (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Modulator.h

diff --git a/third_party/WebKit/Source/core/dom/Modulator.h b/third_party/WebKit/Source/core/dom/Modulator.h

index 41b4ff84eb7b349c9e32f46369322c7be9f20ded..2e6260fefd3952a3c112dbc8210f8d1b39f3d1fb 100644

--- a/third_party/WebKit/Source/core/dom/Modulator.h

+++ b/third_party/WebKit/Source/core/dom/Modulator.h

@@ -92,8 +92,7 @@

// Synchronously retrieves a single module script from existing module map

// entry.

- // Note: returns nullptr if the module map entry doesn't exist, or

- // is still "fetching".

+ // Note: returns nullptr if the module map entry is still "fetching".

virtual ModuleScript* GetFetchedModuleScript(const KURL&) = 0;

// https://html.spec.whatwg.org/#resolve-a-module-specifier