third_party/WebKit/Source/core/dom/ModuleMap.h - Issue 2886123002: Revert of [ES6 modules] ModuleMap::GetFetchedModuleScript to return nullptr when entry not found / "fetching"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ModuleMap.h

Issue 2886123002: Revert of [ES6 modules] ModuleMap::GetFetchedModuleScript to return nullptr when entry not found / "fetching" (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/ModuleMap.h

diff --git a/third_party/WebKit/Source/core/dom/ModuleMap.h b/third_party/WebKit/Source/core/dom/ModuleMap.h

index a7e10bef7431e4b25aa9be955157be37af18c7a4..dcf51d17c8d02732e3add1c941c033da713bd27e 100644

--- a/third_party/WebKit/Source/core/dom/ModuleMap.h

+++ b/third_party/WebKit/Source/core/dom/ModuleMap.h

@@ -41,8 +41,8 @@

SingleModuleClient*);

// Synchronously get the ModuleScript for a given URL.

- // If the URL wasn't fetched, or is currently being fetched, this returns a

- // nullptr.

+ // Note: fetchSingleModuleScript of the ModuleScript must be complete before

+ // calling this.

ModuleScript* GetFetchedModuleScript(const KURL&) const;

Modulator* GetModulator() { return modulator_; }