Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js

Issue 2886073002: DevTools: prep audits panel for Lighthouse roll (Closed)
Patch Set: address feedback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/audits2/audits2Panel.css ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @interface 5 * @interface
6 */ 6 */
7 class LighthousePort { 7 class LighthousePort {
8 /** 8 /**
9 * @param {!string} eventName, 'message', 'close' 9 * @param {!string} eventName, 'message', 'close'
10 * @param {function(string|undefined)} cb 10 * @param {function(string|undefined)} cb
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 .then(/** @type {!ReportRenderer.ReportJSON} */ result => { 49 .then(/** @type {!ReportRenderer.ReportJSON} */ result => {
50 // Filter out artifacts except for screenshots in traces to minimize r eport size. 50 // Filter out artifacts except for screenshots in traces to minimize r eport size.
51 var traces = result.artifacts.traces; 51 var traces = result.artifacts.traces;
52 for (var pass in traces) { 52 for (var pass in traces) {
53 traces[pass]['traceEvents'] = 53 traces[pass]['traceEvents'] =
54 traces[pass]['traceEvents'].filter(e => e['cat'] === 'disabled-b y-default-devtools.screenshot'); 54 traces[pass]['traceEvents'].filter(e => e['cat'] === 'disabled-b y-default-devtools.screenshot');
55 } 55 }
56 result.artifacts = {traces: traces}; 56 result.artifacts = {traces: traces};
57 return result; 57 return result;
58 }) 58 })
59 .catchException(null); 59 .catch(err => ({
60 fatal: true,
61 message: err.message,
62 stack: err.stack,
63 }));
60 } 64 }
61 65
62 /** 66 /**
63 * @return {!Promise} 67 * @return {!Promise}
64 */ 68 */
65 stop() { 69 stop() {
66 this.close(); 70 this.close();
67 return Promise.resolve(); 71 return Promise.resolve();
68 } 72 }
69 73
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 }; 118 };
115 119
116 // Make lighthouse and traceviewer happy. 120 // Make lighthouse and traceviewer happy.
117 global = self; 121 global = self;
118 global.isVinn = true; 122 global.isVinn = true;
119 global.document = {}; 123 global.document = {};
120 global.document.documentElement = {}; 124 global.document.documentElement = {};
121 global.document.documentElement.style = { 125 global.document.documentElement.style = {
122 WebkitAppearance: 'WebkitAppearance' 126 WebkitAppearance: 'WebkitAppearance'
123 }; 127 };
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/audits2/audits2Panel.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698