DevTools: do not use Bindings.NetworkProject.styleHeaderForUISourceCode in SourceFormatter

DevTools: do not use Bindings.NetworkProject.styleHeaderForUISourceCode in SourceFormatter

This patch eliminates usage of styleHeaderForUISourceCode method in
SourceFormatter.

This is a pre-step before removing the styleHeaderForUISourceCode method
from NetworkManager, which, in turn, is a pre-step before moving styles
UISourceCode management into StylesSourcemapping.

BUG=670180
R=caseq, dgozman

Review-Url: https://codereview.chromium.org/2886053002
Cr-Commit-Position: refs/heads/master@{#473340}
Committed: https://chromium.googlesource.com/chromium/src/+/1c17c7939f415f28bedd6c6729d2c5e704885268

[lushnikov, 2017-05-16 23:28:38]

please, take a look

[lushnikov, 2017-05-16 23:36:51]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 23:38:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2017-05-16 23:40:22]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 23:40:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caseq, 2017-05-16 23:54:30]

https://codereview.chromium.org/2886053002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/SourceFormatter.js
(right):

https://codereview.chromium.org/2886053002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourceFormatter.js:283: var
styleHeader = rawLocations.length ? rawLocations[0].header() : null;
Let's take care of all possible headers here?

[lushnikov, 2017-05-17 00:17:50]

please, take another look

https://codereview.chromium.org/2886053002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/SourceFormatter.js
(right):

https://codereview.chromium.org/2886053002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourceFormatter.js:283: var
styleHeader = rawLocations.length ? rawLocations[0].header() : null;
On 2017/05/16 23:54:30, caseq wrote:
> Let's take care of all possible headers here?

Sure!

[lushnikov, 2017-05-17 00:17:56]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 00:18:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caseq, 2017-05-17 00:34:01]

lgtm

[lushnikov, 2017-05-17 00:34:17]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2017-05-17 00:34:23]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-05-17 00:34:25]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2017-05-17 00:34:28]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-05-17 00:36:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 02:58:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 02:58:27]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lushnikov, 2017-05-17 02:59:21]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-05-17 03:00:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 04:22:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 04:22:49]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lushnikov, 2017-05-17 04:30:07]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-05-17 04:31:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 05:50:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 05:50:04]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lushnikov, 2017-05-17 21:19:24]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-05-17 21:20:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 00:38:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 00:38:34]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lushnikov, 2017-05-19 01:30:02]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-05-19 01:31:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 04:29:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 04:29:20]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[lushnikov, 2017-05-19 18:16:18]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-05-19 18:17:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2017-05-19 20:48:28]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2017-05-19 20:48:29]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-05-19 20:48:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 20:48:42]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[lushnikov, 2017-05-19 20:51:54]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-05-19 20:52:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 21:46:45]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495227114942390,
"parent_rev": "e7589a2971c46d73b60b928ff9194da0a8121355", "commit_rev":
"1c17c7939f415f28bedd6c6729d2c5e704885268"}

[commit-bot: I haz the power, 2017-05-19 21:47:00]

Description was changed from

==========
DevTools: do not use Bindings.NetworkProject.styleHeaderForUISourceCode in
SourceFormatter

This patch eliminates usage of styleHeaderForUISourceCode method in
SourceFormatter.

This is a pre-step before removing the styleHeaderForUISourceCode method
from NetworkManager, which, in turn, is a pre-step before moving styles
UISourceCode management into StylesSourcemapping.

BUG=670180
R=caseq, dgozman
==========

to

==========
DevTools: do not use Bindings.NetworkProject.styleHeaderForUISourceCode in
SourceFormatter

This patch eliminates usage of styleHeaderForUISourceCode method in
SourceFormatter.

This is a pre-step before removing the styleHeaderForUISourceCode method
from NetworkManager, which, in turn, is a pre-step before moving styles
UISourceCode management into StylesSourcemapping.

BUG=670180
R=caseq, dgozman

Review-Url: https://codereview.chromium.org/2886053002
Cr-Commit-Position: refs/heads/master@{#473340}
Committed:
https://chromium.googlesource.com/chromium/src/+/1c17c7939f415f28bedd6c6729d2...
==========

[commit-bot: I haz the power, 2017-05-19 21:47:02]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/1c17c7939f415f28bedd6c6729d2...