[ObjC ARC] Converts ios/chrome/browser/ui/main:main to ARC.

[ObjC ARC] Converts ios/chrome/browser/ui/main:main to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2886043003
Cr-Commit-Position: refs/heads/master@{#481918}
Committed: https://chromium.googlesource.com/chromium/src/+/18c51c84da2f5321c0a3252c2776835b79d83827

[stkhapugin, 2017-05-17 14:38:51]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 14:39:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-05-17 15:42:03]

stkhapugin@chromium.org changed reviewers:
+ sdefresne@chromium.org

[stkhapugin, 2017-05-17 15:42:03]

PTAL

[commit-bot: I haz the power, 2017-05-17 16:00:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 16:00:40]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-05-17 16:28:49]

not lgtm as BVW and BVC require adding some logic to have cleanup happen at a
deterministic time. I'm tracking this as
https://bugs.chromium.org/p/chromium/issues/detail?id=722879 and will probably
take ownership of migrating those two classes to ARC.

[sdefresne, 2017-06-15 13:25:56]

I landed the CL that add proper shutdown to BVW. Can you rebase and update your
CL?

[stkhapugin, 2017-06-15 16:34:15]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 16:34:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 16:43:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 16:43:53]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[stkhapugin, 2017-06-22 13:45:36]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 13:45:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-06-22 13:46:24]

Please take a look, Sylvain!

[commit-bot: I haz the power, 2017-06-22 16:30:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 16:30:28]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-06-23 14:37:15]

lgtm with comments

https://codereview.chromium.org/2886043003/diff/40001/ios/chrome/browser/ui/m...
File ios/chrome/browser/ui/main/main_coordinator.h (right):

https://codereview.chromium.org/2886043003/diff/40001/ios/chrome/browser/ui/m...
ios/chrome/browser/ui/main/main_coordinator.h:19: @property(weak, nonatomic,
readonly, nullable)
nit: @property(nonatomic, weak, readonly, nullable) ...

https://codereview.chromium.org/2886043003/diff/40001/ios/chrome/browser/ui/m...
File ios/chrome/browser/ui/main/main_coordinator.mm (right):

https://codereview.chromium.org/2886043003/diff/40001/ios/chrome/browser/ui/m...
ios/chrome/browser/ui/main/main_coordinator.mm:32: MainViewController*
mainViewController = [[MainViewController alloc] init];
nit: remove the local variable

[stkhapugin, 2017-06-23 15:07:16]

Thank you!

https://codereview.chromium.org/2886043003/diff/40001/ios/chrome/browser/ui/m...
File ios/chrome/browser/ui/main/main_coordinator.h (right):

https://codereview.chromium.org/2886043003/diff/40001/ios/chrome/browser/ui/m...
ios/chrome/browser/ui/main/main_coordinator.h:19: @property(weak, nonatomic,
readonly, nullable)
On 2017/06/23 14:37:15, sdefresne wrote:
> nit: @property(nonatomic, weak, readonly, nullable) ...

Done.

https://codereview.chromium.org/2886043003/diff/40001/ios/chrome/browser/ui/m...
File ios/chrome/browser/ui/main/main_coordinator.mm (right):

https://codereview.chromium.org/2886043003/diff/40001/ios/chrome/browser/ui/m...
ios/chrome/browser/ui/main/main_coordinator.mm:32: MainViewController*
mainViewController = [[MainViewController alloc] init];
On 2017/06/23 14:37:15, sdefresne wrote:
> nit: remove the local variable

I cannot, since _mainViewController is weak.

[stkhapugin, 2017-06-23 15:07:33]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-06-23 15:07:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2886043003/#ps60001
(title: "comments")

[commit-bot: I haz the power, 2017-06-23 15:07:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 16:31:56]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498230453019910,
"parent_rev": "37fd3477f0a335abbc3f5ebf6b8121e0be19edba", "commit_rev":
"18c51c84da2f5321c0a3252c2776835b79d83827"}

[commit-bot: I haz the power, 2017-06-23 16:32:10]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/main:main to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/main:main to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2886043003
Cr-Commit-Position: refs/heads/master@{#481918}
Committed:
https://chromium.googlesource.com/chromium/src/+/18c51c84da2f5321c0a3252c2776...
==========

[commit-bot: I haz the power, 2017-06-23 16:32:11]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/18c51c84da2f5321c0a3252c2776...