Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2885993004: Pass the sdk path to plugins (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -29 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +6 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/plugin_manager.dart View 6 chunks +12 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/plugin_manager_test.dart View 9 chunks +22 lines, -13 lines 0 comments Download
M pkg/analyzer_plugin/doc/api.html View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/lib/plugin/plugin.dart View 4 chunks +13 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol_constants.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol_generated.dart View 9 chunks +34 lines, -3 lines 0 comments Download
M pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart View 2 chunks +8 lines, -2 lines 0 comments Download
M pkg/analyzer_plugin/test/integration/support/protocol_matchers.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer_plugin/test/plugin/plugin_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/tool/spec/plugin_spec.html View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 7 months ago (2017-05-17 14:52:08 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-17 15:18:11 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-17 15:19:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
daffcecc11c52ba86add261ce03d8174faf97336 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698