Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart

Issue 2885993004: Pass the sdk path to plugins (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart
diff --git a/pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart b/pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart
index 010d527153cc7bec6f713548695340de2fa97f12..9ff55605fd59d9471dc6297f4027bdeb764570c2 100644
--- a/pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart
+++ b/pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart
@@ -36,6 +36,11 @@ abstract class IntegrationTestMixin {
* The path to the directory containing the on-disk byte store that is to
* be used by any analysis drivers that are created.
*
+ * sdkPath (String)
+ *
+ * The path to the directory containing the SDK that is to be used by any
+ * analysis drivers that are created.
+ *
* version (String)
*
* The version number of the plugin spec supported by the analysis server
@@ -72,8 +77,9 @@ abstract class IntegrationTestMixin {
* should be notified of changes.
*/
Future<PluginVersionCheckResult> sendPluginVersionCheck(
- String byteStorePath, String version) async {
- var params = new PluginVersionCheckParams(byteStorePath, version).toJson();
+ String byteStorePath, String sdkPath, String version) async {
+ var params =
+ new PluginVersionCheckParams(byteStorePath, sdkPath, version).toJson();
var result = await server.send("plugin.versionCheck", params);
ResponseDecoder decoder = new ResponseDecoder(null);
return new PluginVersionCheckResult.fromJson(decoder, 'result', result);

Powered by Google App Engine
This is Rietveld 408576698