Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: third_party/WebKit/Source/platform/animation/TimingFunction.h

Issue 2885983004: Remove DEFINE_STATIC_REF calls from header files (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/animation/TimingFunction.h
diff --git a/third_party/WebKit/Source/platform/animation/TimingFunction.h b/third_party/WebKit/Source/platform/animation/TimingFunction.h
index 55758d6762e915e6bf85380024a5c3ab4600e394..9a7a777c3c36522b90cca9f4779918aae7668cd3 100644
--- a/third_party/WebKit/Source/platform/animation/TimingFunction.h
+++ b/third_party/WebKit/Source/platform/animation/TimingFunction.h
@@ -94,34 +94,7 @@ class PLATFORM_EXPORT CubicBezierTimingFunction final : public TimingFunction {
return AdoptRef(new CubicBezierTimingFunction(x1, y1, x2, y2));
}
- static CubicBezierTimingFunction* Preset(EaseType ease_type) {
- DEFINE_STATIC_REF(
- CubicBezierTimingFunction, ease,
- (AdoptRef(new CubicBezierTimingFunction(EaseType::EASE))));
- DEFINE_STATIC_REF(
- CubicBezierTimingFunction, ease_in,
- (AdoptRef(new CubicBezierTimingFunction(EaseType::EASE_IN))));
- DEFINE_STATIC_REF(
- CubicBezierTimingFunction, ease_out,
- (AdoptRef(new CubicBezierTimingFunction(EaseType::EASE_OUT))));
- DEFINE_STATIC_REF(
- CubicBezierTimingFunction, ease_in_out,
- (AdoptRef(new CubicBezierTimingFunction(EaseType::EASE_IN_OUT))));
-
- switch (ease_type) {
- case EaseType::EASE:
- return ease;
- case EaseType::EASE_IN:
- return ease_in;
- case EaseType::EASE_OUT:
- return ease_out;
- case EaseType::EASE_IN_OUT:
- return ease_in_out;
- default:
- NOTREACHED();
- return nullptr;
- }
- }
+ static CubicBezierTimingFunction* Preset(EaseType);
~CubicBezierTimingFunction() override {}

Powered by Google App Engine
This is Rietveld 408576698