Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 2885983004: Remove DEFINE_STATIC_REF calls from header files (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by alancutter (OOO until 2018)
Modified:
4 months, 1 week ago
Reviewers:
noel, shend, Noel Gordon
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, Eric Willigers, kinuko+watch, rjwright, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DEFINE_STATIC_REF calls from header files This patch moves calls to DEFINE_STATIC_REF from header files to their corresponding source file. DEFINE_STATIC_REF initialises static local variables. They should not be used in header files otherwise separate build components may end up holding onto separate versions of the object. BUG=723295 Review-Url: https://codereview.chromium.org/2885983004 Cr-Commit-Position: refs/heads/master@{#472784} Committed: https://chromium.googlesource.com/chromium/src/+/1d5b2074f9265b918ef7571e13cfc2c2d794d940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -34 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/animation/TimingFunction.h View 1 chunk +1 line, -28 lines 0 comments Download
M third_party/WebKit/Source/platform/animation/TimingFunction.cpp View 1 chunk +29 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 16 (9 generated)
alancutter (OOO until 2018)
4 months, 1 week ago (2017-05-18 05:46:17 UTC) #5
Noel Gordon
LGTM
4 months, 1 week ago (2017-05-18 05:56:13 UTC) #6
shend
wow that sounds bad. lgtm
4 months, 1 week ago (2017-05-18 05:56:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885983004/1
4 months, 1 week ago (2017-05-18 05:59:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/448340)
4 months, 1 week ago (2017-05-18 10:31:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885983004/1
4 months, 1 week ago (2017-05-18 10:48:33 UTC) #13
commit-bot: I haz the power
4 months, 1 week ago (2017-05-18 13:10:50 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1d5b2074f9265b918ef7571e13cf...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b