Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2885873002: Remove generic parameters from type inference classes. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove generic parameters from type inference classes. Previously, these classes were generic because we anticapted re-using them with analyzer AST objects in order to do analyzer type inference. But we've decided on a new technique for doing analyzer type inference: infer at the kernel level and then transfer the inference data to analyzer using the TypeInferenceListener. So the generic parameters are no longer needed. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/d99ba36b5e5617c35add849e9f565f56685a9113

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -86 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 6 chunks +7 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart View 10 chunks +29 lines, -36 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 20 chunks +41 lines, -39 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-16 16:23:13 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-16 16:29:07 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-16 16:35:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d99ba36b5e5617c35add849e9f565f56685a9113 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698