Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart

Issue 2885873002: Remove generic parameters from type inference classes. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
index 6e5e97ded274c344fb44fa6b0d6c89d4da8fb0d9..fc66b07cfe896ecfa70928d9d9b0338ff57aa89f 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
@@ -246,7 +246,7 @@ class KernelExpressionStatement extends ExpressionStatement
class KernelField extends Field {
bool _implicitlyTyped = true;
- FieldNode<KernelField> _fieldNode;
+ FieldNode _fieldNode;
bool _isInferred = false;
@@ -689,7 +689,7 @@ class KernelThrow extends Throw implements KernelExpression {
/// Concrete implementation of [TypeInferenceEngine] specialized to work with
/// kernel objects.
-class KernelTypeInferenceEngine extends TypeInferenceEngineImpl<KernelField> {
+class KernelTypeInferenceEngine extends TypeInferenceEngineImpl {
KernelTypeInferenceEngine(Instrumentation instrumentation, bool strongMode)
: super(instrumentation, strongMode);
@@ -699,8 +699,8 @@ class KernelTypeInferenceEngine extends TypeInferenceEngineImpl<KernelField> {
}
@override
- FieldNode<KernelField> createFieldNode(KernelField field) {
- FieldNode<KernelField> fieldNode = new FieldNode<KernelField>(this, field);
+ FieldNode createFieldNode(KernelField field) {
+ FieldNode fieldNode = new FieldNode(this, field);
field._fieldNode = fieldNode;
return fieldNode;
}
@@ -729,7 +729,7 @@ class KernelTypeInferenceEngine extends TypeInferenceEngineImpl<KernelField> {
}
@override
- List<FieldNode<KernelField>> getFieldDependencies(KernelField field) {
+ List<FieldNode> getFieldDependencies(KernelField field) {
return field._fieldNode?.dependencies;
}
@@ -761,8 +761,7 @@ class KernelTypeInferenceEngine extends TypeInferenceEngineImpl<KernelField> {
/// Concrete implementation of [TypeInferrer] specialized to work with kernel
/// objects.
-class KernelTypeInferrer extends TypeInferrerImpl<Statement, Expression,
- VariableDeclaration, KernelField> {
+class KernelTypeInferrer extends TypeInferrerImpl {
@override
final typePromoter = new KernelTypePromoter();
@@ -776,7 +775,7 @@ class KernelTypeInferrer extends TypeInferrerImpl<Statement, Expression,
}
@override
- FieldNode<KernelField> getFieldNodeForReadTarget(Member readTarget) {
+ FieldNode getFieldNodeForReadTarget(Member readTarget) {
if (readTarget is KernelField) {
return readTarget._fieldNode;
} else {

Powered by Google App Engine
This is Rietveld 408576698