Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(29)

Issue 2885783002: Add ScopedTaskEnvironment::GetMainThreadTaskRunner(). (Closed)

Created:
1 year, 10 months ago by fdoray
Modified:
1 year, 10 months ago
Reviewers:
robliao, gab
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ScopedTaskEnvironment::GetMainThreadTaskRunner(). This will avoid the need to store the main thread TaskRunner in a member variable in tests that need to post to the main thread from other threads (e.g. https://chromium.googlesource.com/chromium/src/+/134190a648fe48fed0486cf8889569863e4a544c/media/capture/video/video_capture_device_unittest.cc#109) BUG=708584 Review-Url: https://codereview.chromium.org/2885783002 Cr-Commit-Position: refs/heads/master@{#472111} Committed: https://chromium.googlesource.com/chromium/src/+/812f416e1368152c31893028eeee7e85bd25e827

Patch Set 1 #

Patch Set 2 : self-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M base/test/scoped_task_environment.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M base/test/scoped_task_environment.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fdoray
PTAL
1 year, 10 months ago (2017-05-16 12:54:09 UTC) #4
gab
lgtm
1 year, 10 months ago (2017-05-16 15:24:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885783002/20001
1 year, 10 months ago (2017-05-16 15:24:28 UTC) #9
commit-bot: I haz the power
1 year, 10 months ago (2017-05-16 15:35:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/812f416e1368152c31893028eeee...

Powered by Google App Engine
This is Rietveld 408576698