Remove references to background_data_ in ComputedStyle.

Remove references to background_data_ in ComputedStyle.

To allow changes to where fields are stored, ComputedStyle code should
not refer directly to a group, as that code will break when we change
groups. This patch removes references to background_data_ in ComputedStyle,
replacing with generated or handwritten getters.

References in the cpp file didn't exist.

BUG=710938
Review-Url: https://codereview.chromium.org/2885753002
Cr-Commit-Position: refs/heads/master@{#472364}
Committed: https://chromium.googlesource.com/chromium/src/+/0e9b44fea13a90aff88c5a0e7e0164fa99e2418a

[nainar, 2017-05-16 07:47:55]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 07:48:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-05-16 07:48:45]

nainar@chromium.org changed reviewers:
+ shend@chromium.org

[nainar, 2017-05-16 07:48:45]

shend@, 

PTAL? Thanks!

[shend, 2017-05-16 07:50:06]

lgtm

https://codereview.chromium.org/2885753002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.h (right):

https://codereview.chromium.org/2885753002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.h:3394: FillLayer&
AccessBackgroundLayers() { return MutableBackgroundInternal(); }
yay these actually have uses :P

[nainar, 2017-05-16 07:51:27]

nainar@chromium.org changed reviewers:
+ alancutter@chromium.org

[nainar, 2017-05-16 07:51:28]

alancutter@, 

PTAL? Thanks!

https://codereview.chromium.org/2885753002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.h (right):

https://codereview.chromium.org/2885753002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.h:3394: FillLayer&
AccessBackgroundLayers() { return MutableBackgroundInternal(); }
On 2017/05/16 at 07:50:06, shend wrote:
> yay these actually have uses :P

lol. :P we are way too excited if this makes us happy!

[alancutter (OOO until 2018), 2017-05-16 08:01:14]

lgtm

[commit-bot: I haz the power, 2017-05-16 09:46:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 09:47:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nainar, 2017-05-17 00:14:36]

The CQ bit was checked by nainar@chromium.org

[commit-bot: I haz the power, 2017-05-17 00:16:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 03:44:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 03:44:28]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nainar, 2017-05-17 04:21:24]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 04:22:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 06:12:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 06:12:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nainar, 2017-05-17 06:12:50]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 06:13:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 06:56:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 06:56:19]

Dry run: This issue passed the CQ dry run.

[nainar, 2017-05-17 06:56:29]

The CQ bit was checked by nainar@chromium.org

[commit-bot: I haz the power, 2017-05-17 06:57:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 07:05:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495004189401610, "parent_rev":
"f473dd30ca79f4d1cbf7234193b0acf2a16b9d0d", "commit_rev":
"0e9b44fea13a90aff88c5a0e7e0164fa99e2418a"}

[commit-bot: I haz the power, 2017-05-17 07:05:39]

Description was changed from

==========
Remove references to background_data_ in ComputedStyle.

To allow changes to where fields are stored, ComputedStyle code should
not refer directly to a group, as that code will break when we change
groups. This patch removes references to background_data_ in ComputedStyle,
replacing with generated or handwritten getters.

References in the cpp file didn't exist.

BUG=710938
==========

to

==========
Remove references to background_data_ in ComputedStyle.

To allow changes to where fields are stored, ComputedStyle code should
not refer directly to a group, as that code will break when we change
groups. This patch removes references to background_data_ in ComputedStyle,
replacing with generated or handwritten getters.

References in the cpp file didn't exist.

BUG=710938

Review-Url: https://codereview.chromium.org/2885753002
Cr-Commit-Position: refs/heads/master@{#472364}
Committed:
https://chromium.googlesource.com/chromium/src/+/0e9b44fea13a90aff88c5a0e7e01...
==========

[commit-bot: I haz the power, 2017-05-17 07:05:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0e9b44fea13a90aff88c5a0e7e01...