Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2885743002: Include only changed or affected libraries into delta. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -45 lines) Patch
M pkg/front_end/lib/incremental_kernel_generator.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/incremental_kernel_generator_impl.dart View 2 chunks +14 lines, -1 line 2 comments Download
M pkg/front_end/test/incremental_kernel_generator_test.dart View 8 chunks +48 lines, -38 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
3 years, 7 months ago (2017-05-16 05:54:52 UTC) #1
Paul Berry
lgtm
3 years, 7 months ago (2017-05-16 12:44:02 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as e118615103334fc022c6b0a1246c96582c2c526c (presubmit successful).
3 years, 7 months ago (2017-05-16 15:49:57 UTC) #4
Siggi Cherem (dart-lang)
https://codereview.chromium.org/2885743002/diff/1/pkg/front_end/lib/src/incremental_kernel_generator_impl.dart File pkg/front_end/lib/src/incremental_kernel_generator_impl.dart (right): https://codereview.chromium.org/2885743002/diff/1/pkg/front_end/lib/src/incremental_kernel_generator_impl.dart#newcode67 pkg/front_end/lib/src/incremental_kernel_generator_impl.dart:67: final Map<Uri, String> _uriToLatestSignature = {}; optional style nit: ...
3 years, 7 months ago (2017-05-17 18:15:10 UTC) #5
scheglov
3 years, 7 months ago (2017-05-17 22:04:05 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/2885743002/diff/1/pkg/front_end/lib/src/incre...
File pkg/front_end/lib/src/incremental_kernel_generator_impl.dart (right):

https://codereview.chromium.org/2885743002/diff/1/pkg/front_end/lib/src/incre...
pkg/front_end/lib/src/incremental_kernel_generator_impl.dart:67: final Map<Uri,
String> _uriToLatestSignature = {};
On 2017/05/17 18:15:10, Siggi Cherem (dart-lang) wrote:
> optional style nit: consider dropping "_uriTo" from the name, I think that's
> implied given the type. Maybe simply "_lastSignature"?

OK
Will do in https://codereview.chromium.org/2893453005.

Powered by Google App Engine
This is Rietveld 408576698