Mix salt into result signatures.

Mix salt into result signatures.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/510ce4d7385f501db759c6bc5030b43a1ac83d0c

[Siggi Cherem (dart-lang), 2017-05-17 22:22:58]

lgtm

[Paul Berry, 2017-05-17 22:25:06]

https://codereview.chromium.org/2893453005/diff/1/pkg/front_end/lib/src/incre...
File pkg/front_end/lib/src/incremental_kernel_generator_impl.dart (right):

https://codereview.chromium.org/2893453005/diff/1/pkg/front_end/lib/src/incre...
pkg/front_end/lib/src/incremental_kernel_generator_impl.dart:270:
_salt.setRange(0, 16, saltBytes);
This doesn't seem safe.  If saltBytes has fewer than 16 bytes, then the behavior
of setRange is undefined (setRange docs say "The [iterable] must have enough
objects to fill the range from `start` to `end` after skipping [skipCount]
objects).  If saltBytes has more than 16 bytes, then some of the salt bytes
won't get copied.

[scheglov, 2017-05-17 22:38:09]

https://codereview.chromium.org/2893453005/diff/1/pkg/front_end/lib/src/incre...
File pkg/front_end/lib/src/incremental_kernel_generator_impl.dart (right):

https://codereview.chromium.org/2893453005/diff/1/pkg/front_end/lib/src/incre...
pkg/front_end/lib/src/incremental_kernel_generator_impl.dart:270:
_salt.setRange(0, 16, saltBytes);
On 2017/05/17 22:25:06, Paul Berry wrote:
> This doesn't seem safe.  If saltBytes has fewer than 16 bytes, then the
behavior
> of setRange is undefined (setRange docs say "The [iterable] must have enough
> objects to fill the range from `start` to `end` after skipping [skipCount]
> objects).  If saltBytes has more than 16 bytes, then some of the salt bytes
> won't get copied.

Hm... I think toByteList() returns exactly 16 bytes of md5 signature.

[scheglov, 2017-05-18 01:13:31]

PTAL

[Paul Berry, 2017-05-18 02:57:15]

Patch sets 1 and 3 both lgtm (feel free to land whichever version you see fit). 
Sorry for the slow response.

https://codereview.chromium.org/2893453005/diff/1/pkg/front_end/lib/src/incre...
File pkg/front_end/lib/src/incremental_kernel_generator_impl.dart (right):

https://codereview.chromium.org/2893453005/diff/1/pkg/front_end/lib/src/incre...
pkg/front_end/lib/src/incremental_kernel_generator_impl.dart:270:
_salt.setRange(0, 16, saltBytes);
On 2017/05/17 22:38:09, scheglov wrote:
> On 2017/05/17 22:25:06, Paul Berry wrote:
> > This doesn't seem safe.  If saltBytes has fewer than 16 bytes, then the
> behavior
> > of setRange is undefined (setRange docs say "The [iterable] must have enough
> > objects to fill the range from `start` to `end` after skipping [skipCount]
> > objects).  If saltBytes has more than 16 bytes, then some of the salt bytes
> > won't get copied.
> 
> Hm... I think toByteList() returns exactly 16 bytes of md5 signature.

Oops, you're right.  I forgot about that.

[scheglov, 2017-05-18 04:00:14]

Description was changed from

==========
Mix salt into result signatures.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
Mix salt into result signatures.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/510ce4d7385f501db759c6bc5030b43a1ac83d0c
==========

[scheglov, 2017-05-18 04:00:15]

Committed patchset #3 (id:40001) manually as
510ce4d7385f501db759c6bc5030b43a1ac83d0c (presubmit successful).