Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2885733002:
Add encrypted VP9 video with profile 2. (Closed)
|
Created:
3 years, 7 months ago by Haoming Chen Modified:
3 years, 7 months ago CC:
chromium-reviews, feature-media-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd encrypted VP9 profile 2 video.
- Add one clear VP9 profile 2 video and two encrypted
versions, in webm and mp4 containers, generated with
shaka packager.
BUG=707128
Review-Url: https://codereview.chromium.org/2885733002
Cr-Commit-Position: refs/heads/master@{#472649}
Committed: https://chromium.googlesource.com/chromium/src/+/dc43ab1dbfab38936813c7ed60d5fa6f35876a7a
Patch Set 1 #Patch Set 2 : Add encrypted VP9 video with profile 2. #
Total comments: 2
Patch Set 3 : Add encrypted VP9 profile 2 video. #Patch Set 4 : rebase #
Messages
Total messages: 34 (19 generated)
Description was changed from ========== Add encrypted VP9 video with profile 2. - Add one clear VP9 profile 2 video and two encrypted versions, in webm and mp4 containers, generated with shaka packager. BUG=707128 ========== to ========== Add encrypted VP9 profile 2 video. - Add one clear VP9 profile 2 video and two encrypted versions, in webm and mp4 containers, generated with shaka packager. BUG=707128 ==========
hmchen@chromium.org changed reviewers: + kqyang@chromium.org, xhwang@chromium.org
Patchset #2 (id:2) has been deleted
Patchset #2 (id:30001) has been deleted
Please review.
Thank you so much for working on this!!! LGTM
Thanks! https://codereview.chromium.org/2885733002/diff/50001/media/test/data/README File media/test/data/README (right): https://codereview.chromium.org/2885733002/diff/50001/media/test/data/README#... media/test/data/README:79: packager in=bear-320x240-vp9_profile2.webm,stream=video,out=bear-320x240-v-vp9_profile2_subsample_cenc-v.webm --enable_fixed_key_encryption --key_id 30313233343536373839303132333435 nit: align "packager" "Encrypted" above
lgtm
hmchen: Could you please also put the codec string (something similar to vp09.00.10.08.01.02.02.02.00) in the README file?
PTAL. https://codereview.chromium.org/2885733002/diff/50001/media/test/data/README File media/test/data/README (right): https://codereview.chromium.org/2885733002/diff/50001/media/test/data/README#... media/test/data/README:79: packager in=bear-320x240-vp9_profile2.webm,stream=video,out=bear-320x240-v-vp9_profile2_subsample_cenc-v.webm --enable_fixed_key_encryption --key_id 30313233343536373839303132333435 On 2017/05/16 17:13:01, kqyang wrote: > nit: align "packager" "Encrypted" above Done.
lgtm++
The CQ bit was checked by hmchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kqyang@chromium.org Link to the patchset: https://codereview.chromium.org/2885733002/#ps70001 (title: "Add encrypted VP9 profile 2 video.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hmchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hmchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org, kqyang@chromium.org Link to the patchset: https://codereview.chromium.org/2885733002/#ps90001 (title: "rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hmchen@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by xhwang@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 90001, "attempt_start_ts": 1495068419723980,
"parent_rev": "f8bc6f196aa3279a2480d224a1f678a6680ceeef", "commit_rev":
"dc43ab1dbfab38936813c7ed60d5fa6f35876a7a"}
Message was sent while issue was closed.
Description was changed from ========== Add encrypted VP9 profile 2 video. - Add one clear VP9 profile 2 video and two encrypted versions, in webm and mp4 containers, generated with shaka packager. BUG=707128 ========== to ========== Add encrypted VP9 profile 2 video. - Add one clear VP9 profile 2 video and two encrypted versions, in webm and mp4 containers, generated with shaka packager. BUG=707128 Review-Url: https://codereview.chromium.org/2885733002 Cr-Commit-Position: refs/heads/master@{#472649} Committed: https://chromium.googlesource.com/chromium/src/+/dc43ab1dbfab38936813c7ed60d5... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:90001) as https://chromium.googlesource.com/chromium/src/+/dc43ab1dbfab38936813c7ed60d5... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
