Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: third_party/polymer/v1_0/chromium.patch

Issue 2885723002: [MD Bookmarks] Add keyboard navigation and selection to bookmark list. (Closed)
Patch Set: address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/polymer/v1_0/chromium.patch
diff --git a/third_party/polymer/v1_0/chromium.patch b/third_party/polymer/v1_0/chromium.patch
index 8b99b23f099dfaa63080fe6a058cbaf9e4286782..add37bdc75bed4c7759ca6e09d60f18071f47bc3 100644
--- a/third_party/polymer/v1_0/chromium.patch
+++ b/third_party/polymer/v1_0/chromium.patch
@@ -16,11 +16,26 @@ index 78a2a9ec621c..8b776dd790ea 100644
@@ -43,8 +43,8 @@ Polymer({
}
},
-
+
- _ariaLabelledByChanged: function(ariaLabelledBy) {
- this.$.input.textarea.setAttribute('aria-labelledby', ariaLabelledBy);
+ _ariaLabelledByChanged: function() {
+ this.$.input.textarea.setAttribute('aria-label', this.label);
},
-
+
_ariaDescribedByChanged: function(ariaDescribedBy) {
+diff --git a/components-chromium/iron-list/iron-list-extracted.js b/components-chromium/iron-list/iron-list-extracted.js
+index c9e0a9fd5330..5d04e7e9db8c 100644
+--- a/components-chromium/iron-list/iron-list-extracted.js
++++ b/components-chromium/iron-list/iron-list-extracted.js
+@@ -1466,6 +1466,10 @@
+ return this._physicalIndexForKey[this._collection.getKey(this._getNormalizedItem(idx))];
+ },
+
++ focusItem: function(idx) {
++ this._focusPhysicalItem(idx);
++ },
++
+ _focusPhysicalItem: function(idx) {
+ if (idx < 0 || idx >= this._virtualCount) {
+ return;

Powered by Google App Engine
This is Rietveld 408576698