Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/polymer/v1_0/chromium.patch

Issue 2885723002: [MD Bookmarks] Add keyboard navigation and selection to bookmark list. (Closed)
Patch Set: address comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 diff --git a/components-chromium/font-roboto/roboto.html b/components-chromium/f ont-roboto/roboto.html 1 diff --git a/components-chromium/font-roboto/roboto.html b/components-chromium/f ont-roboto/roboto.html
2 index 7a24999..4eefcba 100644 2 index 7a24999..4eefcba 100644
3 --- a/components-chromium/font-roboto/roboto.html 3 --- a/components-chromium/font-roboto/roboto.html
4 +++ b/components-chromium/font-roboto/roboto.html 4 +++ b/components-chromium/font-roboto/roboto.html
5 @@ -7,5 +7,4 @@ The complete set of contributors may be found at http://polymer. github.io/CONTRI 5 @@ -7,5 +7,4 @@ The complete set of contributors may be found at http://polymer. github.io/CONTRI
6 Code distributed by Google as part of the polymer project is also 6 Code distributed by Google as part of the polymer project is also
7 subject to an additional IP rights grant found at http://polymer.github.io/PATE NTS.txt 7 subject to an additional IP rights grant found at http://polymer.github.io/PATE NTS.txt
8 --> 8 -->
9 -<link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto:400 ,300,300italic,400italic,500,500italic,700,700italic"> 9 -<link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto:400 ,300,300italic,400italic,500,500italic,700,700italic">
10 -<link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto+Mon o:400,700"> 10 -<link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto+Mon o:400,700">
11 +<link rel="stylesheet" href="chrome://resources/css/roboto.css"> 11 +<link rel="stylesheet" href="chrome://resources/css/roboto.css">
12 diff --git a/components-chromium/paper-input/paper-textarea-extracted.js b/compo nents-chromium/paper-input/paper-textarea-extracted.js 12 diff --git a/components-chromium/paper-input/paper-textarea-extracted.js b/compo nents-chromium/paper-input/paper-textarea-extracted.js
13 index 78a2a9ec621c..8b776dd790ea 100644 13 index 78a2a9ec621c..8b776dd790ea 100644
14 --- a/components-chromium/paper-input/paper-textarea-extracted.js 14 --- a/components-chromium/paper-input/paper-textarea-extracted.js
15 +++ b/components-chromium/paper-input/paper-textarea-extracted.js 15 +++ b/components-chromium/paper-input/paper-textarea-extracted.js
16 @@ -43,8 +43,8 @@ Polymer({ 16 @@ -43,8 +43,8 @@ Polymer({
17 } 17 }
18 }, 18 },
19 19
20 - _ariaLabelledByChanged: function(ariaLabelledBy) { 20 - _ariaLabelledByChanged: function(ariaLabelledBy) {
21 - this.$.input.textarea.setAttribute('aria-labelledby', ariaLabelledBy); 21 - this.$.input.textarea.setAttribute('aria-labelledby', ariaLabelledBy);
22 + _ariaLabelledByChanged: function() { 22 + _ariaLabelledByChanged: function() {
23 + this.$.input.textarea.setAttribute('aria-label', this.label); 23 + this.$.input.textarea.setAttribute('aria-label', this.label);
24 }, 24 },
25 25
26 _ariaDescribedByChanged: function(ariaDescribedBy) { 26 _ariaDescribedByChanged: function(ariaDescribedBy) {
27 diff --git a/components-chromium/iron-list/iron-list-extracted.js b/components-c hromium/iron-list/iron-list-extracted.js
28 index c9e0a9fd5330..5d04e7e9db8c 100644
29 --- a/components-chromium/iron-list/iron-list-extracted.js
30 +++ b/components-chromium/iron-list/iron-list-extracted.js
31 @@ -1466,6 +1466,10 @@
32 return this._physicalIndexForKey[this._collection.getKey(this._getNormali zedItem(idx))];
33 },
34
35 + focusItem: function(idx) {
36 + this._focusPhysicalItem(idx);
37 + },
38 +
39 _focusPhysicalItem: function(idx) {
40 if (idx < 0 || idx >= this._virtualCount) {
41 return;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698