Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2885673002:
MD Settings: Search engines, improve spacing for long keywords. (Closed)
|
Created:
3 years, 7 months ago by dpapad Modified:
3 years, 7 months ago Reviewers:
dschuyler CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: Search engines, improve spacing for long keywords.
BUG=719325
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2885673002
Cr-Commit-Position: refs/heads/master@{#472524}
Committed: https://chromium.googlesource.com/chromium/src/+/e66cc545cc1e3f6fdd36a79b9871d746369fa38e
Patch Set 1 #Patch Set 2 : Fix again. #
Total comments: 1
Messages
Total messages: 17 (11 generated)
Description was changed from ========== MD Settings: Search engines, improve spacing for long keywords. BUG=719325 ========== to ========== MD Settings: Search engines, improve spacing for long keywords. BUG=719325 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dpapad@chromium.org changed reviewers: + dschuyler@chromium.org
Before/after screenshots: http://imgur.com/a/YwPX3 https://codereview.chromium.org/2885673002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/search_engines_page/search_engine_entry.html (right): https://codereview.chromium.org/2885673002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/search_engines_page/search_engine_entry.html:58: <div id="keyword-column"><div>[[engine.keyword]]</div></div> Need to wrap with an extra div, such that the margin is not added on a flex child. Adding margin directly to flex children messes up the table layout (margin is initially subtracted from the available space, then flex children are laid out, then margin is re-added).
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
lgtm
The CQ bit was checked by dpapad@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by dpapad@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495039174724080,
"parent_rev": "d4685bc5518470a729e001859d325000257e6b77", "commit_rev":
"e66cc545cc1e3f6fdd36a79b9871d746369fa38e"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Search engines, improve spacing for long keywords. BUG=719325 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Search engines, improve spacing for long keywords. BUG=719325 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2885673002 Cr-Commit-Position: refs/heads/master@{#472524} Committed: https://chromium.googlesource.com/chromium/src/+/e66cc545cc1e3f6fdd36a79b9871... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/e66cc545cc1e3f6fdd36a79b9871... |
