|
|
Created:
3 years, 7 months ago by Paweł Hajdan Jr. Modified:
3 years, 7 months ago Reviewers:
DaleCurtis CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpstream Gentoo Linux patch for using system ffmpeg
This upstreams https://gitweb.gentoo.org/repo/gentoo.git/tree/www-client/chromium/files/chromium-system-ffmpeg-r6.patch?id=c387b221c37fe243cf51a6e6d1493fd738f633ac
This is intended to be used together with https://cs.chromium.org/chromium/src/build/linux/unbundle/ffmpeg.gn
build/linux/unbundle is a separate directory tree, so that regular
Chromium developers don't need to worry about this configuration.
Please see https://cs.chromium.org/chromium/src/build/linux/unbundle/README?dr
for more context.
BUG=none
R=dalecurtis@chromium.org
Review-Url: https://codereview.chromium.org/2885543003 .
Cr-Commit-Position: refs/heads/master@{#472472}
Committed: https://chromium.googlesource.com/chromium/src/+/44fbc4d877cf871eb8d736b4c53a05bb11588931
Patch Set 1 #
Messages
Total messages: 25 (13 generated)
The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
phajdan.jr@chromium.org changed reviewers: + dalecurtis@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Needs to be switched to a buildflag() ? Or is this not defined anywhere in our build files?
On 2017/05/16 17:54:53, DaleCurtis_OOO_May_5_To_May23 wrote: > Needs to be switched to a buildflag() ? Or is this not defined anywhere in our > build files? Please see the commit message. It is defined in https://cs.chromium.org/chromium/src/build/linux/unbundle/ffmpeg.gn .
On 2017/05/16 at 19:03:08, phajdan.jr wrote: > On 2017/05/16 17:54:53, DaleCurtis_OOO_May_5_To_May23 wrote: > > Needs to be switched to a buildflag() ? Or is this not defined anywhere in our > > build files? > > Please see the commit message. It is defined in https://cs.chromium.org/chromium/src/build/linux/unbundle/ffmpeg.gn . Ah, thanks. Since it's already present, this lgtm but probably these should be BUILDFLAGS now?
The CQ bit was checked by phajdan.jr@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by phajdan.jr@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by phajdan.jr@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by phajdan.jr@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Upstream Gentoo Linux patch for using system ffmpeg This upstreams https://gitweb.gentoo.org/repo/gentoo.git/tree/www-client/chromium/files/chro... This is intended to be used together with https://cs.chromium.org/chromium/src/build/linux/unbundle/ffmpeg.gn build/linux/unbundle is a separate directory tree, so that regular Chromium developers don't need to worry about this configuration. Please see https://cs.chromium.org/chromium/src/build/linux/unbundle/README?dr for more context. BUG=none ========== to ========== Upstream Gentoo Linux patch for using system ffmpeg This upstreams https://gitweb.gentoo.org/repo/gentoo.git/tree/www-client/chromium/files/chro... This is intended to be used together with https://cs.chromium.org/chromium/src/build/linux/unbundle/ffmpeg.gn build/linux/unbundle is a separate directory tree, so that regular Chromium developers don't need to worry about this configuration. Please see https://cs.chromium.org/chromium/src/build/linux/unbundle/README?dr for more context. BUG=none R=dalecurtis@chromium.org Review-Url: https://codereview.chromium.org/2885543003 . Cr-Commit-Position: refs/heads/master@{#472472} Committed: https://chromium.googlesource.com/chromium/src/+/44fbc4d877cf871eb8d736b4c53a... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44fbc4d877cf871eb8d736b4c53a05bb11588931 (presubmit successful). |