Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2885543003: Upstream Gentoo Linux patch for using system ffmpeg (Closed)

Created:
3 years, 7 months ago by Paweł Hajdan Jr.
Modified:
3 years, 7 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream Gentoo Linux patch for using system ffmpeg This upstreams https://gitweb.gentoo.org/repo/gentoo.git/tree/www-client/chromium/files/chromium-system-ffmpeg-r6.patch?id=c387b221c37fe243cf51a6e6d1493fd738f633ac This is intended to be used together with https://cs.chromium.org/chromium/src/build/linux/unbundle/ffmpeg.gn build/linux/unbundle is a separate directory tree, so that regular Chromium developers don't need to worry about this configuration. Please see https://cs.chromium.org/chromium/src/build/linux/unbundle/README?dr for more context. BUG=none R=dalecurtis@chromium.org Review-Url: https://codereview.chromium.org/2885543003 . Cr-Commit-Position: refs/heads/master@{#472472} Committed: https://chromium.googlesource.com/chromium/src/+/44fbc4d877cf871eb8d736b4c53a05bb11588931

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M media/ffmpeg/ffmpeg_common.h View 2 chunks +4 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (13 generated)
Paweł Hajdan Jr.
3 years, 7 months ago (2017-05-16 10:52:34 UTC) #4
DaleCurtis
Needs to be switched to a buildflag() ? Or is this not defined anywhere in ...
3 years, 7 months ago (2017-05-16 17:54:53 UTC) #7
Paweł Hajdan Jr.
On 2017/05/16 17:54:53, DaleCurtis_OOO_May_5_To_May23 wrote: > Needs to be switched to a buildflag() ? Or ...
3 years, 7 months ago (2017-05-16 19:03:08 UTC) #8
DaleCurtis
On 2017/05/16 at 19:03:08, phajdan.jr wrote: > On 2017/05/16 17:54:53, DaleCurtis_OOO_May_5_To_May23 wrote: > > Needs ...
3 years, 7 months ago (2017-05-16 19:29:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885543003/1
3 years, 7 months ago (2017-05-17 08:20:35 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/457196)
3 years, 7 months ago (2017-05-17 11:21:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885543003/1
3 years, 7 months ago (2017-05-17 11:25:19 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/457241)
3 years, 7 months ago (2017-05-17 13:08:17 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885543003/1
3 years, 7 months ago (2017-05-17 13:35:17 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/457378)
3 years, 7 months ago (2017-05-17 15:34:32 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885543003/1
3 years, 7 months ago (2017-05-17 16:03:27 UTC) #23
Paweł Hajdan Jr.
3 years, 7 months ago (2017-05-17 16:29:08 UTC) #25
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
44fbc4d877cf871eb8d736b4c53a05bb11588931 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698