Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Issue 2885543002: Make sure StatisticsRecorder::Initialize() is called at initialization (Closed)

Created:
3 years, 7 months ago by kapishnikov
Modified:
3 years, 7 months ago
Reviewers:
lilyhoughton, mef
CC:
chromium-reviews, cbentzel+watch_chromium.org, ios-reviews_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure StatisticsRecorder::Initialize() is called at initialization Also, add DCHECK that CronetEnvironment::Initialize() is called on the main thread. The current implementation guarantees that when [Cronet start] method returns, the CronetEnvironment singleton is initialized, and, as the result, base::StatisticsRecorder::Initialize() has been invoked. BUG=707836 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2885543002 Cr-Commit-Position: refs/heads/master@{#472555} Committed: https://chromium.googlesource.com/chromium/src/+/a3c5a020f874bbd3a311ab325b541c4db2e100ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/cronet/ios/cronet_environment.mm View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
kapishnikov
PTAL
3 years, 7 months ago (2017-05-15 19:28:40 UTC) #3
mef
lgtm
3 years, 7 months ago (2017-05-17 20:11:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885543002/1
3 years, 7 months ago (2017-05-17 20:13:34 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 20:51:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a3c5a020f874bbd3a311ab325b54...

Powered by Google App Engine
This is Rietveld 408576698