Remove non-Android handling in LargeIconSource

Remove non-Android handling in LargeIconSource

This CL is in preparation to deleting FallbackIconService

BUG=None

Review-Url: https://codereview.chromium.org/2885523002
Cr-Commit-Position: refs/heads/master@{#473208}
Committed: https://chromium.googlesource.com/chromium/src/+/cc4d2c53f23d0e9a694ff7d7ec78c4e982b1f8fa

[pkotwicz, 2017-05-15 19:12:12]

Description was changed from

==========
Remove non-Android handling in LargeIconSource

This CL is in preparation to delete FallbackIconService

BUG=None
==========

to

==========
Remove non-Android handling in LargeIconSource

This CL is in preparation to deleting FallbackIconService

BUG=None
==========

[pkotwicz, 2017-05-15 19:14:08]

pkotwicz@chromium.org changed reviewers:
+ dpapad@chromium.org

[pkotwicz, 2017-05-15 19:14:09]

dpapad@ can you please take a look? This CL depends on
https://codereview.chromium.org/2873383002/

My understanding is that with https://codereview.chromium.org/2873383002/
LargeIconSource is no longer used on non-Android

[pkotwicz, 2017-05-15 19:14:09]

dpapad@ can you please take a look? This CL depends on
https://codereview.chromium.org/2873383002/

My understanding is that with https://codereview.chromium.org/2873383002/
LargeIconSource is no longer used on non-Android

[dpapad, 2017-05-15 23:07:50]

On 2017/05/15 at 19:14:09, pkotwicz wrote:
> dpapad@ can you please take a look? This CL depends on
https://codereview.chromium.org/2873383002/
> 
> My understanding is that with https://codereview.chromium.org/2873383002/
LargeIconSource is no longer used on non-Android

@pkotwicz: I am not familiar with any of that code. Having said that,

large_icon_source.h/cc are still included for non-Android at
https://cs.chromium.org/chromium/src/chrome/browser/ui/BUILD.gn?q=large_icon_....
If these are truly not used in non-Android, can you update the GN file to only
include them in Android?

[pkotwicz, 2017-05-16 16:11:46]

dpapad@ can you please take another look? I have changed large_icon_source.h/cc
to no longer be included on Android

[dpapad, 2017-05-16 17:10:58]

On 2017/05/16 at 16:11:46, pkotwicz wrote:
> dpapad@ can you please take another look? I have changed
large_icon_source.h/cc to no longer be included on Android
'
LGTM. I suggest filing a bug that provides context for this CL, and all other
CLS that are related (the ones mentioned at comment#3), and provide the bug
number as "BUG=". This way it will be easier for someone in the future to
understand why this CL landed in the first place.

[dpapad, 2017-05-16 17:15:13]

https://codereview.chromium.org/2885523002/diff/40001/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/2885523002/diff/40001/chrome/browser/ui/BUILD...
chrome/browser/ui/BUILD.gn:663: sources += [
Nit: Perhaps merge the previous condition with this one?


 if (is_android) {
    sources += [
      "webui/large_icon_source.cc",
      "webui/large_icon_source.h",
    ]
  } else {
    sources += [
      "apps/app_info_dialog.h",
      ...
    ]
    ...
  }

[pkotwicz, 2017-05-17 21:54:56]

pkotwicz@chromium.org changed reviewers:
+ dbeam@chromium.org

[pkotwicz, 2017-05-17 21:54:57]

dbeam@ can you please take a look at the changes in browsing_history_handler.cc
?

dpapad@ I have updated BUILD.gn as requested

[Dan Beam, 2017-05-19 01:12:23]

lgtm

[pkotwicz, 2017-05-19 14:05:03]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2017-05-19 14:05:04]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2885523002/#ps60001
(title: "Merge branch 'master' into searchbox2")

[commit-bot: I haz the power, 2017-05-19 14:05:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 16:15:05]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495202703793610,
"parent_rev": "5abd72f99b1df16fd4a36fba8db370484ead3eb6", "commit_rev":
"cc4d2c53f23d0e9a694ff7d7ec78c4e982b1f8fa"}

[commit-bot: I haz the power, 2017-05-19 16:15:16]

Description was changed from

==========
Remove non-Android handling in LargeIconSource

This CL is in preparation to deleting FallbackIconService

BUG=None
==========

to

==========
Remove non-Android handling in LargeIconSource

This CL is in preparation to deleting FallbackIconService

BUG=None

Review-Url: https://codereview.chromium.org/2885523002
Cr-Commit-Position: refs/heads/master@{#473208}
Committed:
https://chromium.googlesource.com/chromium/src/+/cc4d2c53f23d0e9a694ff7d7ec78...
==========

[commit-bot: I haz the power, 2017-05-19 16:15:17]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cc4d2c53f23d0e9a694ff7d7ec78...