Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1401)

Issue 2885503002: md settings: Remove level of security indicator on lock screen. (Closed)

Created:
3 years, 7 months ago by sammiequon
Modified:
3 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

md settings: Remove level of security indicator on lock screen. Secuirty does not want users to know the level of security on their lock screen unlock method. TEST=manual BUG=722458 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2885503002 Cr-Commit-Position: refs/heads/master@{#471966} Committed: https://chromium.googlesource.com/chromium/src/+/0d2bac567d775397058622d6434702ede6c1d580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/people_page/lock_screen.html View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
sammiequon
stevenjb@ - Please take a look. Thanks!
3 years, 7 months ago (2017-05-15 18:18:10 UTC) #4
stevenjb
lgtm
3 years, 7 months ago (2017-05-15 18:52:13 UTC) #5
sammiequon
On 2017/05/15 18:52:13, stevenjb wrote: > lgtm Thanks!
3 years, 7 months ago (2017-05-15 19:42:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885503002/1
3 years, 7 months ago (2017-05-15 19:42:57 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/426980)
3 years, 7 months ago (2017-05-15 21:40:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885503002/1
3 years, 7 months ago (2017-05-16 00:47:04 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 01:13:35 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0d2bac567d775397058622d64347...

Powered by Google App Engine
This is Rietveld 408576698